WIP: Rework custom deployment controller to library-go DeploymentController #635
Conversation
openshift-ci
bot
added
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jsafrane The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
jsafrane
force-pushed
the
remove-deploymentcontroller
branch
from
184efa7 to
8040103
Compare
Prepare for the code refactoring. This does not change any behavior, just adds necessary scaffolding for replacing code with DeploymentConntroller-compatible hooks.
jsafrane
force-pushed
the
remove-deploymentcontroller
branch
from
8040103 to
7a263c4
Compare
|
Looks like we broke Storage on hypershift:
|
| if len(c.postStartHooks) > 0 { | ||
| controller = controller.WithPostStartHooks(c.postStartHooks...) | ||
| } | ||
|
|
There was a problem hiding this comment.
yes, I need to add it to library-go. If we decide that this PR looks as a good approach.
Use DeploymentController to manage Deployment. Remove the custom controller. Ad move functions from the original controller to global functions, so they can be used by the hooks.
And all other <short name>_Progressing. The new DeploymentController will create <short name>SSIDriverOperatorDeployment_Progressing as documented in the code.
jsafrane
force-pushed
the
remove-deploymentcontroller
branch
from
7a263c4 to
e054102
Compare
|
/test hypershift-aws-e2e-external |
|
/test hypershift-aws-e2e-external |
|
@jsafrane: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
2 participants
Rework custom
CommonCSIDeploymentController/CSIDriverOperatorDeploymentController/HyperShiftDeploymentControllerto use the default DeploymentController.The refactoring is taken in small steps
PostStartHook. Hack it intovendor/, I'll move it into library-go during review.<short name>Progressing(such asGCPPDProgressing) and<short name>CSIDriverOperatorDeploymentDegraded(GCPPDCSIDriverOperatorDeploymentDegraded). The new DeploymentController progressing condition have the long prefix instead. So add a stale condition remover with the old<short name>Progressingconditions.