Skip to content

CNTRLPLANE-2621: Restart operator when TLS config changes#860

Open
lance5890 wants to merge 1 commit intoopenshift:masterfrom
lance5890:TLS-config_inject_cvo
Open

CNTRLPLANE-2621: Restart operator when TLS config changes#860
lance5890 wants to merge 1 commit intoopenshift:masterfrom
lance5890:TLS-config_inject_cvo

Conversation

@lance5890
Copy link
Copy Markdown

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 29, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Mar 29, 2026

@lance5890: This pull request references CNTRLPLANE-2621 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

related to openshift/cluster-version-operator#1322 and
openshift/library-go#657

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6ab7eeca-b957-44f4-9407-bbdd9977aaa8

📥 Commits

Reviewing files that changed from the base of the PR and between 9d60ca2 and c15c0f9.

📒 Files selected for processing (2)
  • manifests/03_configmap.yaml
  • manifests/07_deployment.yaml

Walkthrough

Modifies authentication operator manifests to enable TLS injection on ConfigMap, removes network binding configuration from operator config, and updates deployment to monitor additional config file for pod termination.

Changes

Cohort / File(s) Summary
ConfigMap Manifest
manifests/03_configmap.yaml
Added TLS injection annotation to ConfigMap metadata and removed servingInfo.bindNetwork setting from embedded operator configuration.
Deployment Manifest
manifests/07_deployment.yaml
Extended container termination file monitoring to include operator config file in addition to existing CA bundle file.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot requested review from everettraven and ibihim March 29, 2026 12:30
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 29, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance5890
Once this PR has been reviewed and has the lgtm label, please assign ibihim for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci bot commented Mar 29, 2026

@lance5890: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-operator-encryption-perf-serial-ote-1of2 c15c0f9 link false /test e2e-aws-operator-encryption-perf-serial-ote-1of2
ci/prow/e2e-aws-operator-encryption-serial-ote-2of2 c15c0f9 link false /test e2e-aws-operator-encryption-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-serial-ote-1of2 c15c0f9 link false /test e2e-aws-operator-encryption-serial-ote-1of2
ci/prow/e2e-aws-operator-encryption-rotation-serial-ote-1of2 c15c0f9 link false /test e2e-aws-operator-encryption-rotation-serial-ote-1of2
ci/prow/e2e-aws-operator-encryption-rotation-serial-ote-2of2 c15c0f9 link false /test e2e-aws-operator-encryption-rotation-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-kms-serial-ote-1of2 c15c0f9 link false /test e2e-aws-operator-encryption-kms-serial-ote-1of2
ci/prow/e2e-aws-operator-serial-ote c15c0f9 link false /test e2e-aws-operator-serial-ote
ci/prow/e2e-aws-operator-parallel-ote c15c0f9 link false /test e2e-aws-operator-parallel-ote
ci/prow/e2e-aws-operator-encryption-perf-serial-ote-2of2 c15c0f9 link false /test e2e-aws-operator-encryption-perf-serial-ote-2of2
ci/prow/e2e-aws-operator-encryption-kms-serial-ote-2of2 c15c0f9 link false /test e2e-aws-operator-encryption-kms-serial-ote-2of2

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants