WIP: external oidc uses new oauth-apiserver mode#858
WIP: external oidc uses new oauth-apiserver mode#858everettraven wants to merge 2 commits intoopenshift:masterfrom
Conversation
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Excluded labels (none allowed) (1)
Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Skipping CI for Draft Pull Request. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
TODO: Add tests here
| // conditionally sync the auth-config configmap from the openshift-config-managed namespace | ||
| // to the openshift-oauth-apiserver if OIDC is available. | ||
| // This precondition never returns an error to prevent unnecesary degradation. |
There was a problem hiding this comment.
TODO: decide whether or not this is reasonable over updating the external oidc controller to just write the config directly to the openshift-oauth-apiserver namespace.
Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
No description provided.