Skip to content

ACM-29247: infrastructure operator set up renovate configuration to automatically create hive api synchronization p rs#1511

Open
shay23bra wants to merge 1 commit intoopenshift:masterfrom
shay23bra:ACM-29247-Infrastructure-Operator-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs
Open

ACM-29247: infrastructure operator set up renovate configuration to automatically create hive api synchronization p rs#1511
shay23bra wants to merge 1 commit intoopenshift:masterfrom
shay23bra:ACM-29247-Infrastructure-Operator-Set-up-Renovate-configuration-to-automatically-create-Hive-API-Synchronization-PRs

Conversation

@shay23bra
Copy link
Contributor

  • Enable gomod manager for Go dependency updates
  • Add Hive API package rule for github.com/openshift/hive/apis
  • Configure automatic PR creation with hive-api and api-sync labels
  • Group updates under 'Hive API Synchronization'
  • Preserve existing Docker image and Konflux pipeline configuration

@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 15, 2026

@shay23bra: This pull request references ACM-29247 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

  • Enable gomod manager for Go dependency updates
  • Add Hive API package rule for github.com/openshift/hive/apis
  • Configure automatic PR creation with hive-api and api-sync labels
  • Group updates under 'Hive API Synchronization'
  • Preserve existing Docker image and Konflux pipeline configuration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Feb 15, 2026
@coderabbitai
Copy link

coderabbitai bot commented Feb 15, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2026
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@renovate.json`:
- Around line 11-15: The Renovate config currently enables "gomod" in the
enabledManagers array which will create PRs for every Go dependency; restrict
gomod to only Hive API by adding packageRules under "packageRules" that target
manager:"gomod" and matchPackageNames:"github.com/openshift/hive/apis"
(enable/update for that package) and add a second packageRule for
manager:"gomod" that disables updates for all other Go packages (e.g.,
matchPackageNames:"*" with enabled:false or matchPackagePatterns to exclude
hive), or remove "gomod" from enabledManagers if you don't want any gomod PRs;
update the existing Hive API package rule (the one currently configuring
grouping/labels) to be explicit about manager:"gomod" and the matchPackageNames
value to ensure only that package is handled.

Comment on lines 11 to 15
"enabledManagers": [
"custom.regex",
"tekton"
"tekton",
"gomod"
],
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟠 Major

Enabling gomod will create PRs for all Go dependencies, not just Hive API.

Adding gomod to enabledManagers will cause Renovate to propose updates for every dependency in your go.mod file, not just github.com/openshift/hive/apis. The package rule on lines 135-148 only configures grouping and labels for Hive API — it doesn't disable updates for other packages.

If you only want Hive API synchronization PRs, consider adding a rule to disable all other gomod updates:

Proposed fix to limit gomod updates to Hive API only
         },
         {
             "matchManagers": [
                 "gomod"
             ],
             "matchPackageNames": [
                 "github.com/openshift/hive/apis"
             ],
             "groupName": "Hive API Synchronization",
             "addLabels": [
                 "hive-api",
                 "api-sync"
             ],
             "enabled": true
+        },
+        {
+            "matchManagers": [
+                "gomod"
+            ],
+            "excludePackageNames": [
+                "github.com/openshift/hive/apis"
+            ],
+            "enabled": false
         }
     ]
 }
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"enabledManagers": [
"custom.regex",
"tekton"
"tekton",
"gomod"
],
"packageRules": [
{
"matchManagers": [
"gomod"
],
"matchPackageNames": [
"github.com/openshift/hive/apis"
],
"groupName": "Hive API Synchronization",
"addLabels": [
"hive-api",
"api-sync"
],
"enabled": true
},
{
"matchManagers": [
"gomod"
],
"excludePackageNames": [
"github.com/openshift/hive/apis"
],
"enabled": false
}
]
🤖 Prompt for AI Agents
In `@renovate.json` around lines 11 - 15, The Renovate config currently enables
"gomod" in the enabledManagers array which will create PRs for every Go
dependency; restrict gomod to only Hive API by adding packageRules under
"packageRules" that target manager:"gomod" and
matchPackageNames:"github.com/openshift/hive/apis" (enable/update for that
package) and add a second packageRule for manager:"gomod" that disables updates
for all other Go packages (e.g., matchPackageNames:"*" with enabled:false or
matchPackagePatterns to exclude hive), or remove "gomod" from enabledManagers if
you don't want any gomod PRs; update the existing Hive API package rule (the one
currently configuring grouping/labels) to be explicit about manager:"gomod" and
the matchPackageNames value to ensure only that package is handled.

@codecov
Copy link

codecov bot commented Feb 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.28%. Comparing base (46bcff8) to head (f2c51e8).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1511   +/-   ##
=======================================
  Coverage   48.28%   48.28%           
=======================================
  Files          20       20           
  Lines        4316     4316           
=======================================
  Hits         2084     2084           
  Misses       2011     2011           
  Partials      221      221           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@openshift-ci
Copy link

openshift-ci bot commented Feb 15, 2026

@shay23bra: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@ngraham20 ngraham20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Feb 17, 2026
@openshift-ci
Copy link

openshift-ci bot commented Feb 17, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ngraham20, shay23bra
Once this PR has been reviewed and has the lgtm label, please assign ori-amizur for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants