-
Notifications
You must be signed in to change notification settings - Fork 8
add cloud-nuke process #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
|
||
| # Dry run cloud-nuke to see what resources would be deleted | ||
| cloud-nuke-dry-run: | ||
| @DISABLE_TELEMETRY=true ./scripts/cloud-nuke.py --dry-run --region $${AWS_REGION:-us-east-1} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
issue: Here and below, I would not expect this env var to always be set, you could use aws configure get region to get it dynamically for either profiles/env vars.
| @@ -0,0 +1,244 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like we don't need this script, it essentially does the same that should be built into cloud-nuke, as that should already be using the current AWS profile / envs natively?
| cloud-nuke --version | ||
|
|
||
| # Dry run cloud-nuke to see what resources would be deleted | ||
| cloud-nuke-dry-run: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion: we can make the install a dependency to running cloud-nuke. It could be as simple as checking if it's not installed, then insteall, otherwise NOOP.
|
PR needs rebase. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Important Review skippedAuto reviews are limited based on label configuration. 🚫 Review skipped — only excluded labels are configured. (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
This adds a new cloud-nuke process.
Run
make install-cloud-nuketo install cloud-nuke locallyRun
make cloud-nuke-dry-runto see what will be deletedThis will request you provide additional input of the account number to ensure you nuke the correct account. Everything will be deleted in the specified AWS account. Add exclusions to
configs/cloud-nuke.yaml.Add additional regions to
configs/cloud-nuke.yamlor provide them with the nuke call. Example:AWS_REGION=us-west-2 make cloud-nuke