Skip to content

Conversation

@theautoroboto
Copy link
Collaborator

@theautoroboto theautoroboto commented Jan 28, 2026

This adds a new cloud-nuke process.

Run make install-cloud-nuke to install cloud-nuke locally
Run make cloud-nuke-dry-run to see what will be deleted
This will request you provide additional input of the account number to ensure you nuke the correct account. Everything will be deleted in the specified AWS account. Add exclusions to configs/cloud-nuke.yaml.
Add additional regions to configs/cloud-nuke.yaml or provide them with the nuke call. Example: AWS_REGION=us-west-2 make cloud-nuke

@openshift-ci openshift-ci bot requested review from cdoan1 and syncrou January 28, 2026 19:43
@openshift-ci
Copy link

openshift-ci bot commented Jan 28, 2026

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign jmelis for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment


# Dry run cloud-nuke to see what resources would be deleted
cloud-nuke-dry-run:
@DISABLE_TELEMETRY=true ./scripts/cloud-nuke.py --dry-run --region $${AWS_REGION:-us-east-1}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

issue: Here and below, I would not expect this env var to always be set, you could use aws configure get region to get it dynamically for either profiles/env vars.

@@ -0,0 +1,244 @@
#!/usr/bin/env python3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like we don't need this script, it essentially does the same that should be built into cloud-nuke, as that should already be using the current AWS profile / envs natively?

cloud-nuke --version

# Dry run cloud-nuke to see what resources would be deleted
cloud-nuke-dry-run:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion: we can make the install a dependency to running cloud-nuke. It could be as simple as checking if it's not installed, then insteall, otherwise NOOP.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 30, 2026
@openshift-merge-robot
Copy link
Collaborator

PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@coderabbitai
Copy link

coderabbitai bot commented Jan 30, 2026

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)
  • do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

  • 🔍 Trigger a full review
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants