Overhaul tooling by RadekManak · Pull Request #63 · openshift-eng/rebasebot

RadekManak · 2025-06-10T12:34:10Z

This PR primarily brings in uv for dependency management and ruff for linting and auto formatting.

uv simplifies venv management and ensures tests run with the minimal set of specified dependencies.
ruff combines all formatting and linting rules into one step. Improving performance and enabling auto format.
Make targets are updated to make full advantage of uv and ruff
ContainerFile is updated to python 3.12 and go 1.24.3
All tooling configuration is now in pyproject.toml
Autoformat was run, and minor changes were made to fix new lint rules.

Draft until openshift/release#65749 merges

openshift-ci · 2025-06-10T12:34:15Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

damdo

/approve

Thanks @RadekManak that's a nice update!
I'll add my LGTM once CI is green

openshift-ci · 2025-06-16T08:39:55Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo, RadekManak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [RadekManak,damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

damdo · 2025-06-26T12:27:25Z

+	echo "=== Debug Information ==="
+	echo "Current working directory: $(pwd)"
+	echo "Current user: $(whoami)"
+	echo "Current user ID: $(id)"


IIRC you need to use double dollars in Make to escape shell dollars. e.g. $$(pwd)

RadekManak · 2025-06-26T12:40:47Z

/retest

RadekManak · 2025-06-27T12:40:19Z

/retest

RadekManak · 2025-06-27T13:31:27Z

/retest

RadekManak · 2025-06-27T13:56:48Z

/retest

RadekManak · 2025-06-27T14:37:24Z

/retest

coderabbitai · 2026-03-18T22:36:00Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Excluded labels (none allowed) (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 222bb2b6-1034-47d4-a883-c58f03a9f7af

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

RadekManak · 2026-04-13T10:37:45Z

/test

RadekManak · 2026-04-13T10:37:58Z

/test all

RadekManak · 2026-04-13T20:11:00Z

/test all

Lock the direct build, runtime, and dev dependencies to exact versions and refresh uv.lock so CI uses a reproducible toolchain. Update the PR title failure path to use a specific exception so the pinned Ruff version passes lint cleanly.

Add local build_root/src image targets and a unittest stage so CI failures can be reproduced with the same locked environment.

RadekManak · 2026-04-14T06:52:59Z

/test all

Keep the CI deps path on --no-install-project and disable pytest cache so Prow-style runs do not try to write into the source checkout.

RadekManak · 2026-04-14T07:29:27Z

/test all

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 10, 2025

openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 10, 2025

RadekManak mentioned this pull request Jun 10, 2025

Check merged upstream PR is included in source branch before dropping #64

Merged

RadekManak marked this pull request as ready for review June 11, 2025 15:48

openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 11, 2025

openshift-ci bot requested review from damdo and nrb June 11, 2025 15:48

RadekManak force-pushed the overhaul-tooling branch from fa1d197 to fc76737 Compare June 11, 2025 16:27

damdo reviewed Jun 16, 2025

View reviewed changes

RadekManak force-pushed the overhaul-tooling branch 2 times, most recently from a4a5175 to 6982d0b Compare June 26, 2025 12:26

damdo reviewed Jun 26, 2025

View reviewed changes

RadekManak marked this pull request as draft June 26, 2025 12:35

openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jun 26, 2025

RadekManak force-pushed the overhaul-tooling branch from 6982d0b to bdb5fb8 Compare June 27, 2025 12:34

RadekManak force-pushed the overhaul-tooling branch from bdb5fb8 to ef468e1 Compare June 27, 2025 13:23

RadekManak force-pushed the overhaul-tooling branch 2 times, most recently from 1390ce1 to 2be846c Compare June 27, 2025 13:56

RadekManak force-pushed the overhaul-tooling branch from 2be846c to 56851ca Compare June 27, 2025 14:37

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 18, 2026

RadekManak force-pushed the overhaul-tooling branch from 56851ca to 9850020 Compare April 13, 2026 10:03

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2026

openshift-ci bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2026

RadekManak force-pushed the overhaul-tooling branch from e34236b to 1f8cc21 Compare April 13, 2026 19:55

openshift-ci bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 13, 2026

RadekManak added 3 commits April 14, 2026 08:51

Overhaul tooling

ca9fa04

Pin exact dependencies for stable CI

e35ccb6

Lock the direct build, runtime, and dev dependencies to exact versions and refresh uv.lock so CI uses a reproducible toolchain. Update the PR title failure path to use a specific exception so the pinned Ruff version passes lint cleanly.

Mirror Prow test containers locally

71a9feb

Add local build_root/src image targets and a unittest stage so CI failures can be reproduced with the same locked environment.

RadekManak force-pushed the overhaul-tooling branch from 1f8cc21 to 766334a Compare April 14, 2026 06:52

Avoid read-only checkout writes in CI

07ccc94

Keep the CI deps path on --no-install-project and disable pytest cache so Prow-style runs do not try to write into the source checkout.

RadekManak force-pushed the overhaul-tooling branch from 766334a to 07ccc94 Compare April 14, 2026 07:25

Conversation

RadekManak commented Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci bot commented Jun 10, 2025

Uh oh!

damdo left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci bot commented Jun 16, 2025

Uh oh!

damdo Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

RadekManak commented Jun 26, 2025

Uh oh!

RadekManak commented Jun 27, 2025

Uh oh!

RadekManak commented Jun 27, 2025

Uh oh!

RadekManak commented Jun 27, 2025

Uh oh!

RadekManak commented Jun 27, 2025

Uh oh!

coderabbitai bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

RadekManak commented Apr 13, 2026

Uh oh!

RadekManak commented Apr 13, 2026

Uh oh!

RadekManak commented Apr 13, 2026

Uh oh!

RadekManak commented Apr 14, 2026

Uh oh!

RadekManak commented Apr 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

RadekManak commented Jun 10, 2025 •

edited

Loading

coderabbitai bot commented Mar 18, 2026 •

edited

Loading