Support Docker distribution builds for ppc64le, arm64 and s390x#20678
Support Docker distribution builds for ppc64le, arm64 and s390x#20678reta merged 1 commit intoopensearch-project:mainfrom
Conversation
Signed-off-by: Andriy Redko <drreta@gmail.com>
4994f89 to
f32374d
Compare
|
No actionable comments were generated in the recent review. 🎉 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
🔇 Additional comments (2)
📝 WalkthroughWalkthroughThis pull request extends Docker distribution build support to three additional CPU architectures: ppc64le, arm64, and s390x. The changes add corresponding case branches in the Dockerfile's tini binary selection logic alongside existing architecture mappings, with an accompanying changelog entry documenting the addition. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
❌ Gradle check result for f32374d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f32374d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f32374d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for f32374d: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #20678 +/- ##
============================================
- Coverage 73.19% 73.16% -0.03%
+ Complexity 71924 71909 -15
============================================
Files 5781 5781
Lines 329292 329396 +104
Branches 47514 47525 +11
============================================
- Hits 241026 241011 -15
- Misses 68925 69114 +189
+ Partials 19341 19271 -70 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Description
Support Docker distribution builds for ppc64le, arm64 and s390x. I got access to a few boxes found out the Docker containers we build only target aarch64/x86, however
tinisupport ppc64le, arm64 and s390x as well (see please https://github.com/krallin/tini/releases).Related Issues
N/A
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.