Skip to content

Support Docker distribution builds for ppc64le, arm64 and s390x#20678

Merged
reta merged 1 commit intoopensearch-project:mainfrom
reta:add.more.docker.distributions
Feb 19, 2026
Merged

Support Docker distribution builds for ppc64le, arm64 and s390x#20678
reta merged 1 commit intoopensearch-project:mainfrom
reta:add.more.docker.distributions

Conversation

@reta
Copy link
Contributor

@reta reta commented Feb 19, 2026

Description

Support Docker distribution builds for ppc64le, arm64 and s390x. I got access to a few boxes found out the Docker containers we build only target aarch64/x86, however tini support ppc64le, arm64 and s390x as well (see please https://github.com/krallin/tini/releases).

Related Issues

N/A

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@reta reta requested a review from a team as a code owner February 19, 2026 13:23
Signed-off-by: Andriy Redko <drreta@gmail.com>
@reta reta force-pushed the add.more.docker.distributions branch from 4994f89 to f32374d Compare February 19, 2026 13:24
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 19, 2026

No actionable comments were generated in the recent review. 🎉

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 628aa3d and f32374d.

📒 Files selected for processing (2)
  • CHANGELOG.md
  • distribution/docker/src/docker/Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (19)
  • GitHub Check: gradle-check
  • GitHub Check: assemble (21, ubuntu-latest)
  • GitHub Check: assemble (21, ubuntu-24.04-arm)
  • GitHub Check: assemble (25, windows-latest)
  • GitHub Check: assemble (25, ubuntu-24.04-arm)
  • GitHub Check: assemble (25, ubuntu-latest)
  • GitHub Check: assemble (21, windows-latest)
  • GitHub Check: precommit (21, windows-latest)
  • GitHub Check: precommit (25, windows-latest)
  • GitHub Check: precommit (21, ubuntu-latest)
  • GitHub Check: precommit (25, ubuntu-latest)
  • GitHub Check: Analyze (java)
  • GitHub Check: precommit (21, macos-15-intel)
  • GitHub Check: precommit (21, macos-15)
  • GitHub Check: precommit (21, windows-2025, true)
  • GitHub Check: precommit (21, ubuntu-24.04-arm)
  • GitHub Check: precommit (25, macos-15-intel)
  • GitHub Check: precommit (25, macos-15)
  • GitHub Check: precommit (25, ubuntu-24.04-arm)
🔇 Additional comments (2)
CHANGELOG.md (1)

32-32: Changelog entry looks good.

distribution/docker/src/docker/Dockerfile (1)

31-37: No action needed; tini v0.19.0 includes ppc64le and s390x assets.

The v0.19.0 release of tini provides all required binaries and checksums for the new architectures added in lines 34–36, including tini-ppc64le, tini-s390x, and their .sha256sum files. The build will not fail on these architectures.

Likely an incorrect or invalid review comment.


📝 Walkthrough

Walkthrough

This pull request extends Docker distribution build support to three additional CPU architectures: ppc64le, arm64, and s390x. The changes add corresponding case branches in the Dockerfile's tini binary selection logic alongside existing architecture mappings, with an accompanying changelog entry documenting the addition.

Changes

Cohort / File(s) Summary
Architecture Support Addition
CHANGELOG.md, distribution/docker/src/docker/Dockerfile
Added support for ppc64le, arm64, and s390x CPU architectures in Docker builds. Dockerfile updated with new case branches mapping these architectures to their respective tini binaries; changelog entry added to document the fix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Suggested labels

Build

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly summarizes the main change: adding support for Docker distribution builds for three additional CPU architectures (ppc64le, arm64, s390x).
Description check ✅ Passed The description includes the required sections with meaningful content: a clear description of the change and its motivation, related issues marked as N/A, and the checklist present. Required sections are completed.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@reta reta added enhancement Enhancement or improvement to existing feature or request v3.6.0 Issues and PRs related to version 3.6.0 and removed skip-changelog labels Feb 19, 2026
@github-actions
Copy link
Contributor

❌ Gradle check result for f32374d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for f32374d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for f32374d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for f32374d: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

✅ Gradle check result for f32374d: SUCCESS

@reta reta merged commit ca5d599 into opensearch-project:main Feb 19, 2026
50 of 58 checks passed
@codecov
Copy link

codecov bot commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.16%. Comparing base (db0a16d) to head (f32374d).
⚠️ Report is 13 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main   #20678      +/-   ##
============================================
- Coverage     73.19%   73.16%   -0.03%     
+ Complexity    71924    71909      -15     
============================================
  Files          5781     5781              
  Lines        329292   329396     +104     
  Branches      47514    47525      +11     
============================================
- Hits         241026   241011      -15     
- Misses        68925    69114     +189     
+ Partials      19341    19271      -70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Enhancement or improvement to existing feature or request v3.6.0 Issues and PRs related to version 3.6.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments