Skip to content

Change result type to accept multiple batches#20667

Merged
sandeshkr419 merged 4 commits intoopensearch-project:feature/datafusionfrom
alchemist51:fix-aggs
Feb 19, 2026
Merged

Change result type to accept multiple batches#20667
sandeshkr419 merged 4 commits intoopensearch-project:feature/datafusionfrom
alchemist51:fix-aggs

Conversation

@alchemist51
Copy link
Contributor

Description

[Describe what this change achieves]

Related Issues

Resolves #[Issue number to be closed when this PR is merged]

Check List

  • Functionality includes testing.
  • API changes companion pull request created, if applicable.
  • Public documentation issue/PR created, if applicable.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 18, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

❌ Gradle check result for 098249a: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 15b6091: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

@github-actions
Copy link
Contributor

❌ Gradle check result for 830c897: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

private final QueryShardContext queryShardContext;
private DatafusionQuery datafusionQuery;
private Map<String, Object[]> dfResults;
private Map<String, List<Object>> dfResults;
Copy link
Contributor

@expani expani Feb 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider putting this inside it's own class, something like

interface DataFusionResult {
   void addResult(Object[] values);
   Object getValueAt(String key, int index);
}

class InMemoryDataFusionResult implements DataFusionResult { 
  Map<String, List<Object>> dfResults;
} 

If the initial implementation did this ( partially on me ), the change of Object[] -> List<Object[]> would be contained within this class and not require changes across all aggregators.

In future, if we use a different data structure it can be easily replaced as well.

Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
@github-actions
Copy link
Contributor

❌ Gradle check result for 20197ba: FAILURE

Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change?

Copy link
Contributor

@expani expani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iteration @alchemist51

@sandeshkr419 sandeshkr419 merged commit 84381c7 into opensearch-project:feature/datafusion Feb 19, 2026
8 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants

Comments