Change result type to accept multiple batches#20667
Change result type to accept multiple batches#20667sandeshkr419 merged 4 commits intoopensearch-project:feature/datafusionfrom
Conversation
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
❌ Gradle check result for 098249a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
plugins/engine-datafusion/src/main/java/org/opensearch/datafusion/DatafusionEngine.java
Show resolved
Hide resolved
|
❌ Gradle check result for 15b6091: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
|
❌ Gradle check result for 830c897: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
| private final QueryShardContext queryShardContext; | ||
| private DatafusionQuery datafusionQuery; | ||
| private Map<String, Object[]> dfResults; | ||
| private Map<String, List<Object>> dfResults; |
There was a problem hiding this comment.
Should we consider putting this inside it's own class, something like
interface DataFusionResult {
void addResult(Object[] values);
Object getValueAt(String key, int index);
}
class InMemoryDataFusionResult implements DataFusionResult {
Map<String, List<Object>> dfResults;
}
If the initial implementation did this ( partially on me ), the change of Object[] -> List<Object[]> would be contained within this class and not require changes across all aggregators.
In future, if we use a different data structure it can be easily replaced as well.
Signed-off-by: Arpit Bandejiya <abandeji@amazon.com>
plugins/engine-datafusion/src/main/java/org/opensearch/datafusion/DatafusionEngine.java
Outdated
Show resolved
Hide resolved
|
❌ Gradle check result for 20197ba: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
expani
left a comment
There was a problem hiding this comment.
Thanks for the iteration @alchemist51
84381c7
into
opensearch-project:feature/datafusion
Description
[Describe what this change achieves]
Related Issues
Resolves #[Issue number to be closed when this PR is merged]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.