Add cache initialization for existing files in DatafusionEngine#20645
Add cache initialization for existing files in DatafusionEngine#20645cocosz wants to merge 1 commit intoopensearch-project:feature/datafusionfrom
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing touches🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Comment |
Signed-off-by: Tanvir Alam <tanvralm@amazon.com>
70d5573 to
c9018ca
Compare
|
❌ Gradle check result for c9018ca: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
Description
This PR adds eager cache initialization for existing files in the DatafusionEngine constructor. Previously, files were only added to the cache during refresh operations, which meant the first query after engine initialization would experience cache misses. This change improves query performance by pre-populating the cache with existing files at initialization time.
Benefits
Testing
Added
testExistingFilesAddedToCacheOnInitialization()test that verifies:Tested with Clickbench dataset showing: