Minor tweaks to agent Gradle logic#19711
Minor tweaks to agent Gradle logic#19711andrross wants to merge 1 commit intoopensearch-project:mainfrom
Conversation
|
❌ Gradle check result for 86ee553: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
force-pushed
the
agent-gradle-configuration
branch
from
86ee553 to
12c6702
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #19711 +/- ##
============================================
- Coverage 73.25% 73.19% -0.07%
+ Complexity 71612 71542 -70
============================================
Files 5785 5785
Lines 326905 326899 -6
Branches 47280 47280
============================================
- Hits 239480 239264 -216
- Misses 68220 68376 +156
- Partials 19205 19259 +54 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andrross
force-pushed
the
agent-gradle-configuration
branch
from
12c6702 to
2a4cb7a
Compare
|
❌ Gradle check result for 2a4cb7a: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
force-pushed
the
agent-gradle-configuration
branch
from
2a4cb7a to
593dca4
Compare
|
❌ Gradle check result for 593dca4: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
force-pushed
the
agent-gradle-configuration
branch
from
593dca4 to
748e6cc
Compare
|
❌ Gradle check result for 748e6cc: FAILURE Please examine the workflow log, locate, and copy-paste the failure(s) below, then iterate to green. Is the failure a flaky test unrelated to your change? |
andrross
force-pushed
the
agent-gradle-configuration
branch
from
748e6cc to
15c5fa9
Compare
While doing some other Gradle changes I ran into some really odd failures that ultimately led me down a rabbit hole that resulted in some changes that better match best practices: - Change distribution/build.gradle to use an agent configuration as opposed to taking a direct task dependency. This is how it gets artifacts from other subprojects and is a Gradle best practice. - Defer the evalution of the agent jar file until task execution which also makes the logic less brittle to other Gradle changes. - Make `prepareAgent` depend on `jar` as opposed to the other way around. This removes the need for other projects that need the jar file to depend on anything other than the `jar` task. Signed-off-by: Andrew Ross <andrross@amazon.com>
andrross
force-pushed
the
agent-gradle-configuration
branch
from
15c5fa9 to
57e3db6
Compare
|
This PR is stalled because it has been open for 30 days with no activity. |
1 participant
While doing some other Gradle changes I ran into some really odd failures that ultimately led me down a rabbit hole that resulted in some changes that better match best practices:
prepareAgentdepend onjaras opposed to the other way around. This removes the need for other projects that need the jar file to depend on anything other than thejartask.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.