Enhance DuplicateQueueEntryException with constructors, i18n support, and context fields #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I changed :
Added overloaded constructors for DuplicateQueueEntryException:
With Throwable cause for exception chaining.
With patientId and queueId for more context.
With i18n message codes and parameters for localization support.
Introduced optional fields (patientId, queueId) to provide structured debugging information.
Added Javadoc for clarity and maintainability.
Updated to use modern @serial annotation for serialVersionUID.
Why I changed it:
Makes error handling more flexible and informative.
Supports OpenMRS internationalization standards (messages.properties).
Improves developer experience by providing context directly in the exception.
Aligns with modern Java practices.
How to test:
Try to add the same patient twice to the same queue.
Catch the thrown DuplicateQueueEntryException.
Verify that:
The exception contains the patient ID and queue ID.
Localized error messages are displayed when using the i18n constructor.