Skip to content

Comments

(chore) Update the billing module version to the latest snapshot#955

Closed
NethmiRodrigo wants to merge 1 commit intomainfrom
chore/upgrade-billing
Closed

(chore) Update the billing module version to the latest snapshot#955
NethmiRodrigo wants to merge 1 commit intomainfrom
chore/upgrade-billing

Conversation

@NethmiRodrigo
Copy link
Contributor

This PR updates the version of the billing module to the latest snapshot.

Its worth noting that even though the billing backend starts up, I see two errors when processing payments and updates to the bill line items where somehow the frontend sends undefined instead of the bill UUID, I assume it was probably because of some change in the data model in the backend that we will need to update in the frontend - I’ll look into it and file a PR for it.

For context, the error:

Screen.Recording.2026-01-08.at.11.43.47.PM.mov

@dkayiwa
Copy link
Member

dkayiwa commented Jan 8, 2026

Are we ignoring the E2E test failures for now? 😊

@denniskigen
Copy link
Member

I'm trying to sort them out

@ibacher
Copy link
Member

ibacher commented Jan 8, 2026

This, however, is more E2E failures than we should have I think...

@NethmiRodrigo
Copy link
Contributor Author

The e2e tests are failing because of the toast that is at the top warning about unresolved backend dependencies. The toast is blocking some of the elements that the e2e tests tries to access. The patient-orders-app has a required version of ^1.2.0-SNAPSHOT which somehow isn’t satisfied by 2.0.0.

@NethmiRodrigo
Copy link
Contributor Author

@dkayiwa @denniskigen @ibacher filed this PR - openmrs/openmrs-esm-patient-chart#2930 to fix this

@ibacher
Copy link
Member

ibacher commented Jan 9, 2026

which somehow isn’t satisfied by 2.0.0

Quick lesson on NPM SemVer ranges:

  • a version starting with a caret (^) is compatible with any version equal to or greater than it with the same major version, so ^1 is equivalent to >= 1, < 2 and ^1.2.3 is equivalent to >= 1.2.3, < 2
  • a version starting with a tilde (~) is compatible with any version equal to or greater than it with the same minor version so ~1 is equivalent to >= 1.0, < 1.1 and ~1.2.3 is equivalent to >= 1.2.3, < 1.3.

So ^1.2.0 doesn't work here because it's interpreted as >= 1.2.0, < 2 and 2.0.0-SNAPSHOT is not less than 2.

@NethmiRodrigo
Copy link
Contributor Author

NethmiRodrigo commented Jan 14, 2026

Looking at the failing dispensing e2e test, the error is that it cannot click on the History and comments tab on a patient’s specific active prescription. What the does is, it dispenses a prescription, and usually the workflow is that after the user clicks the dispense button, the active prescription tab stays open (as in the screenshot). In this case, however, the list of active prescriptions appears to refresh (which is a behaviour I cannot replicate on dev3).
Screenshot 2026-01-14 at 1 45 19 PM

I tried to recreate this behaviour on my local instance (built from this branch), and more concerning is that I cannot place a drug order because I get the error [Cannot invoke "org.openmrs.module.webservices.rest.web.resource.api.Converter.newInstance(String)" because "converter" is null].

Screen.Recording.2026-01-14.at.1.41.54.PM.mov

@NethmiRodrigo NethmiRodrigo force-pushed the chore/upgrade-billing branch 2 times, most recently from f173974 to 0c5106d Compare January 14, 2026 11:54
@ibacher ibacher changed the title (chore): Update the billing module version to the latest snapshot (chore) Update the billing module version to the latest snapshot Jan 15, 2026
@dkayiwa
Copy link
Member

dkayiwa commented Jan 19, 2026

@NethmiRodrigo in regards to the error that you are getting on your local instance, when clicking Sign and close, for the encounter endpoint, does the payload have a non empty value for encounterDatetime?

@NethmiRodrigo
Copy link
Contributor Author

Closing this since this got done in #961

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants