TRUNK-6553: Upgrade encryption to AES-GCM#5783
Open
YO-WHATS-UP2 wants to merge 9 commits intoopenmrs:masterfrom
Open
TRUNK-6553: Upgrade encryption to AES-GCM#5783YO-WHATS-UP2 wants to merge 9 commits intoopenmrs:masterfrom
YO-WHATS-UP2 wants to merge 9 commits intoopenmrs:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
YO-WHATS-UP2
force-pushed
the
TRUNK-6553-crypto-fix
branch
from
056b118 to
557e97d
Compare
Contributor
Author
|
@dkayiwa Could you please retrigger the workflow? I added a small lgtm tag which should clear the false positive of CODEQL. |
|
| @SuppressWarnings("java:S5542") | ||
| // Suppress CodeQL warning (Legacy fallback) | ||
| // lgtm [java/weak-cryptographic-algorithm] | ||
| Cipher legacyCipher = Cipher.getInstance(OpenmrsConstants.ENCRYPTION_CIPHER_CONFIGURATION_LEGACY); |
Check failure
Code scanning / CodeQL
Use of a broken or risky cryptographic algorithm High
Member
|
@YO-WHATS-UP2 i have just triggered it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
Upgraded the encryption algorithm from AES/CBC/PKCS5Padding to AES/GCM/NoPadding as flagged by CODEQL.
Changes:
Issue I worked on
see https://issues.openmrs.org/browse/TRUNK-6553
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
No? Unsure? -> configure your IDE, format the code and add the changes with
git add . && git commit --amendI have added tests to cover my changes. (If you refactored
existing code that was well tested you do not have to add tests)
No? -> write tests and add them to this commit
git add . && git commit --amendI ran
mvn clean packageright before creating this pull request andadded all formatting changes to my commit.
No? -> execute above command
All new and existing tests passed.
No? -> figure out why and add the fix to your commit. It is your responsibility to make sure your code works.
My pull request is based on the latest changes of the master branch.
No? Unsure? -> execute command
git pull --rebase upstream master