TRUNK-6522: Switch Obs domain to annotations#5719
Draft
kmvipin wants to merge 4 commits intoopenmrs:masterfrom
Draft
TRUNK-6522: Switch Obs domain to annotations#5719kmvipin wants to merge 4 commits intoopenmrs:masterfrom
kmvipin wants to merge 4 commits intoopenmrs:masterfrom
Conversation
dkayiwa
reviewed
Jan 29, 2026
|
|
||
|
|
||
| @Column(name = "status", length = 16, nullable = false) | ||
| @Enumerated(EnumType.STRING) |
Member
There was a problem hiding this comment.
For the error that you are getting, try adding this on this field: @JdbcTypeCode(SqlTypes.VARCHAR)
Contributor
Author
There was a problem hiding this comment.
Sure, I will implement this!
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of what I changed
TRUNK-6522: Switch Obs domain to annotations
Converted Obs.java from XML-based Hibernate mapping to JPA/Hibernate annotations. This change eliminates the need for Obs.hbm.xml mapping file by adding appropriate annotations directly to the domain class:
The Obs.hbm.xml file can now be removed as all mapping configuration is handled through annotations.
Issue I worked on
see https://openmrs.atlassian.net/browse/TRUNK-6522
Checklist: I completed these to help reviewers :)
My IDE is configured to follow the code style of this project.
My pull request is based on the latest changes of the master branch.
Note : this PR currently in development