Draft
Conversation
Copy-paste SpatialLegendreFilter. No other changes needed. Could be combined to a SpatialExpansionFilter header?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses Part 1 of #3815 . Implements a new functional expansion tally basis in space: spatial Fourier. This borrows heavily from the implementation of spatial Legendre.
SpatialFourierFilter.SpatialExpansionFilteras a parent ofSpatialFourierFilterandSpatialLegendreFilteron the Python side. Moved most ofSpatialLegendreFilterto its parent.Checklist
I have made corresponding changes to the documentation (if applicable)Discussion
SpatialExpansionFilterbase class be implemented on the C++ side as well?sqrt(2). I believe that the convention for FETs in OpenMC is to normalize in postprocessing (though I'm not sure if this is explicitly established: see Return actual functional representation of funcational expansion tallies in Python API #3419).Details
Running on the example problem from example-filters.ipynb: