Update backend to handle .json files in SUPPORTED_DISTROS#237
Update backend to handle .json files in SUPPORTED_DISTROS#237nikhilshinde63 wants to merge 2 commits intoopenmainframeproject:react-frontendfrom
Conversation
Signed-off-by: Nikhil-Shinde7 <Nikhil.Shinde7@ibm.com>
Signed-off-by: Nikhil-Shinde7 <Nikhil.Shinde7@ibm.com>
nikhilshinde63
force-pushed
the
backend-frontend-integration
branch
from
c63161d to
f8f2f2b
Compare
pleia2
left a comment
pleia2
left a comment
There was a problem hiding this comment.
The changes to the Python files are fine, but we do want to continue using the .example file and ignoring supported_distros.py so we can more easily do upgrades.
| @@ -1,3 +1,2 @@ | |||
| *.pyc | |||
| .env | |||
| src/config/supported_distros.py | |||
There was a problem hiding this comment.
So, the reason we ignore this is when we're running this in production this file will probably be edited by the user based on what distributions they want to support. We don't want it overwritten when we pull in the new code from git.
That's why we ship with the .example file that the user then copies into this location.
pleia2
left a comment
pleia2
left a comment
There was a problem hiding this comment.
Tested with the bin/database_build.py script, noted the below issues I had when running it.
Once these .json extension are added back to the file system references, it created the databases as expected.
Ignore this one, when used with the supported_distros.py with the .json extension, it worked as expected. I think the python scripts are OK. |
2 participants
No description provided.