Skip to content

Conversation

@sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Nov 24, 2025

Hi all,

This pull request contains a backport of commit e18e95ed from the openjdk/jdk repository.

Clean backport to make test more robustness, change has been verified locally on linux-x64. Test-fix only, no risk.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8346962 needs maintainer approval

Issue

  • JDK-8346962: Test CRLReadTimeout.java fails with -Xcomp on a fastdebug build (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2487/head:pull/2487
$ git checkout pull/2487

Update a local copy of the PR:
$ git checkout pull/2487
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2487/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2487

View PR using the GUI difftool:
$ git pr show -t 2487

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2487.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 24, 2025

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Nov 24, 2025

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346962: Test CRLReadTimeout.java fails with -Xcomp on a fastdebug build

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 40 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport e18e95ed11c1df7eeb162c2303f027564ed6f6aa 8346962: Test CRLReadTimeout.java fails with -Xcomp on a fastdebug build Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Nov 24, 2025
@openjdk
Copy link

openjdk bot commented Nov 24, 2025

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Nov 24, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 24, 2025

Webrevs

@openjdk
Copy link

openjdk bot commented Nov 28, 2025

@sendaoYan This pull request has not yet been marked as ready for integration.

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 29, 2025

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@sendaoYan
Copy link
Member Author

/approval request Clean backport to make test more robustness, change has been verified locally on linux-x64. Test-fix only, no risk.

@openjdk
Copy link

openjdk bot commented Dec 29, 2025

@sendaoYan
8346962: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Dec 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required ready Pull request is ready to be integrated rfr Pull request is ready for review

Development

Successfully merging this pull request may close these issues.

1 participant