Fix non-datetime field handling of datetime with the date editor widget #6902
+16
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
🍎 MacOS DMG universal buildsDownload a MacOS DMG universal build of this PR for testing. 🐧 Linux AppImage buildsDownload a Linux AppImage build of this PR for testing. 🪟 Windows buildsDownload a Windows build of this PR for testing. |
Collaborator
|
🎉 Ta-daaa, freshly created APKs are available for 17460c7: arm64-android |
3 tasks
nirvn
force-pushed
the
datetime_editor_widget
branch
from
4a0a97a to
17460c7
Compare
kaustuvpokharel
approved these changes
Dec 16, 2025
| const textDate = Qt.formatDateTime(currentDate, !!config['field_iso_format'] ? Qt.ISODate : config['field_format']); | ||
| let dateFormat = config['display_format'] !== undefined ? config['display_format'] : ''; | ||
| if (!!config['field_format_overwrite']) { | ||
| dateFormat = !!config['field_iso_format'] ? 'yyyy-MM-dd HH:mm:ss+t' : config['field_format']; |
Collaborator
There was a problem hiding this comment.
@nirvn in what case is this condition triggered ? Just curious
Member
Author
There was a problem hiding this comment.
@kaustuvpokharel , explanation coming when I reach my workstation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6898