Allow customizing CompactSubGeometry.#66
Draft
player-03 wants to merge 14 commits intoopenfl:masterfrom
Draft
Conversation
…es `CompactSubGeometry` includes. Most users likely don't need "secondary UVs", for instance, and could save memory by omitting them. Others might want to add a custom 4-length attribute.
Collaborator
Author
|
Oh, and I wrote this for Haxe 4.3+, so that's another reason it's still a draft. |
Without that, the clone will interpret all its data incorrectly.
This reduces duplicate code and allows activating custom attributes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most users likely don't need "secondary UVs", for instance, and could save memory by omitting them. Others might want to add a custom 4-length attribute (not fully implemented; you can define them but they'll be ignored).
Sample usage:
This sub-geometry allocates only 5 floats per vertex, instead of 13, massively reducing buffer size.