emonPi_CM firmware fixes - Fix receiving in JEELIB_NATIVE mode, Fix transmit in both modes #148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix transmitting to match expected format from EmonHubOEMInterfacer (also matches how transmission has been done before and works with emonglcd) Remove verbose mode and associated Serial.prints to get more room in flash. Verbose mode is spurious as config changes can be verified with 'l' and 'L' options, and was disabled by default. Without removing these there was no room in flash for the code. Consideration could be given in future to make the help more terse and reducing the large amount of Serial.prints uin the code to gain further space
Contributor
Author
|
It would also be nice to have this as compiled firmware available for emonPi users (JEELIB_NATIVE) as I can't be the only one who updated all my RF devices (gmonlcds, emonths, emonpi (x2) and emontx3) to this format when Robert introduced emonLibCM with great fanfare on the forum.. :) I can't do a wholesale convert to LPL due to also having a large number of rf12 devices in my ecosystem too (using jeelib RF69_COMPAT). |
Member
|
Thanks for this @alandpearson, just acknowledging for now, I haven't had a chance to test this yet but appreciate the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RX print_frame function for loop to start at index 2 when using JEELIB_NATIVE format (otherwise sending node id is incorrectly printed twice on the serial FRAME).
Fix transmitting to match expected CSV format sent from EmonHubOEMInterfacer (also matches how transmission has been done in all other DS firmware versions and works with emonglcd and other devices).
Remove verbose mode and associated Serial.prints to get more room in flash. Verbose mode is spurious as config changes can be verified with 'l' and 'L' options, and was disabled by default. Without removing these there was no room in flash for the code. Consideration could be given in future to make the help more terse and reducing the large amount of Serial.prints throughout the code to gain further space.
Bump version number.