Skip to content

Conversation

@kiran1415
Copy link

Fix LTI integration issue with X LTI Provider by adding non-core institution roles

LTI integration with the X LTI Provider was failing because non-core institution
roles (specifically the Learner role) were not included. This commit adds the
required non-core Learner role to resolve the issue. No impact to existing
implementations or integrations.

Doc: https://www.imsglobal.org/spec/lti/v1p3
image

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Nov 20, 2025
@openedx-webhooks
Copy link

Thanks for the pull request, @kiran1415!

This repository is currently maintained by @Faraz32123.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Nov 20, 2025
@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Nov 25, 2025
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Needs Tests Run or CLA Signed in Contributions Nov 25, 2025
@e0d
Copy link
Contributor

e0d commented Dec 10, 2025

@kiran1415 Thanks for your contribution! It looks like there are some failing checks. Can you have a look?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 10, 2025
@e0d e0d moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Dec 10, 2025
@kiran1415
Copy link
Author

@e0d fixed the issue
could you please rerun the test

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 19, 2025
@mphilbrick211 mphilbrick211 moved this from Waiting on Author to Needs Tests Run or CLA Signed in Contributions Dec 19, 2025
@Faraz32123 Faraz32123 self-requested a review January 2, 2026 06:01
@Faraz32123
Copy link
Contributor

@kiran1415 Can you please take a look on failing tests again!
Thanks for the contribution.

@mphilbrick211 mphilbrick211 removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Jan 5, 2026
@mphilbrick211 mphilbrick211 moved this from Needs Tests Run or CLA Signed to Waiting on Author in Contributions Jan 5, 2026
@mphilbrick211
Copy link

mphilbrick211 commented Jan 22, 2026

@kiran1415 Can you please take a look on failing tests again! Thanks for the contribution.

Friendly ping on this, @kiran1415

@mphilbrick211 mphilbrick211 moved this from Waiting on Author to In Eng Review in Contributions Jan 22, 2026
@mphilbrick211 mphilbrick211 added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc.

Projects

Status: In Eng Review

Development

Successfully merging this pull request may close these issues.

5 participants