Skip to content

Conversation

@filippovskii09
Copy link

@filippovskii09 filippovskii09 commented Jan 8, 2026

Description

Provide add a size prop with the values 'sm' | 'md' | 'lg' for the Sheet component

Issues

#3023

Preview

2026-01-08.11.00.38.mov

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jan 8, 2026
@openedx-webhooks
Copy link

openedx-webhooks commented Jan 8, 2026

Thanks for the pull request, @filippovskii09!

This repository is currently maintained by @openedx/committers-paragon.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@netlify
Copy link

netlify bot commented Jan 8, 2026

Deploy Preview for paragon-openedx-v23 ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 76bfac4
🔍 Latest deploy log https://app.netlify.com/projects/paragon-openedx-v23/deploys/6968c8c20fc56a0008e55d81
😎 Deploy Preview https://deploy-preview-4075--paragon-openedx-v23.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-project-automation github-project-automation bot moved this to Needs Triage in Contributions Jan 8, 2026
@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.39%. Comparing base (9d7ceef) to head (76bfac4).
⚠️ Report is 6 commits behind head on release-23.x.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-23.x    #4075   +/-   ##
=============================================
  Coverage         94.39%   94.39%           
=============================================
  Files               242      242           
  Lines              4296     4297    +1     
  Branches           1013     1021    +8     
=============================================
+ Hits               4055     4056    +1     
  Misses              233      233           
  Partials              8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@filippovskii09 filippovskii09 self-assigned this Jan 8, 2026
@filippovskii09 filippovskii09 marked this pull request as ready for review January 8, 2026 16:13
@mphilbrick211 mphilbrick211 moved this from Needs Triage to Ready for Review in Contributions Jan 8, 2026
@mphilbrick211 mphilbrick211 requested a review from a team January 8, 2026 16:30
Copy link
Contributor

@PKulkoRaccoonGang PKulkoRaccoonGang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR, left a few comments

Comment on lines 14 to 16
"sm": { "value": "400px" },
"md": { "value": "500px" },
"lg": { "value": "800px" }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add the $ for value -> $value and run the build using the npm run build-tokens command

Suggested change
"sm": { "value": "400px" },
"md": { "value": "500px" },
"lg": { "value": "800px" }
"sm": { "$value": "400px" },
"md": { "$value": "500px" },
"lg": { "$value": "800px" }

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

open-source-contribution PR author is not from Axim or 2U

Projects

Status: Ready for Review

Development

Successfully merging this pull request may close these issues.

4 participants