feat: Only display Preview Language Setting (dark_lang) in LMS #36271
Conversation
kdmccormick
added
the
create-sandbox
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
kdmccormick
force-pushed
the
kdmccormick/update-lang-lms-redirect
branch
from
c8fb0c7 to
a44d8e9
Compare
|
Sandbox deployment successful 🚀 |
|
Sandbox deployment successful 🚀 |
kdmccormick
force-pushed
the
kdmccormick/update-lang-lms-redirect
branch
from
a44d8e9 to
9e90da8
Compare
|
Sandbox deployment successful 🚀 |
kdmccormick
force-pushed
the
kdmccormick/update-lang-lms-redirect
branch
from
9e90da8 to
52eab57
Compare
|
Sandbox deployment failed 💥 |
|
Sandbox deployment successful 🚀 |
kdmccormick
removed
the
create-sandbox
Previously, there were two (identical) ways to preview dark language: 1. <CMS_ROOT_URL>/update_lang 2. <LMS_ROOT_URL>/update_lang Now, (1) will simply redirect to (2). So, the Preview Language Setting page will only render in an LMS context. This has no impact on end-user functionality. It has only a very minor UX end-user impact. The purpose of this is to allow us to completely retire the legacy Studio frontend without losing any end-user functionality. This page is not yet available in an MFE, which will need to be the eventual solution.
kdmccormick
force-pushed
the
kdmccormick/update-lang-lms-redirect
branch
from
52eab57 to
3dd8acc
Compare
2 participants
Description
We disable the Studio Preview Language Setting Page, and redirect it to the identical LMS Preview Language Setting page. This is one of the final bits of the legacy Studio frontend. By making it render only in LMS, we unblock the full retirement of the legacy Studio frontend.
Supporting info
Before
There were two views allowing to staff to choose to preview a "dark" language, both of which are completely identical in functionality. The only difference is the header, footer, and styling surrounding them.
1. Studio Context (
<CMS_ROOT_URL>/update_lang)2. LMS Context (
<LMS_ROOT_URL>/update_lang)After
The Studio URL (1) will simply redirect to the LMS URL (2). In other words, the Preview Language Setting page will only render in an LMS context.
This has no impact on end-user functionality. It has only a very minor UX end-user impact (LMS header+footer rather than Studio header+footer). The LMS styling seems to be better, anyway.
Test instructions
<CMS_BASE>/update_lang<LMS_BASE>/update_lang.es)Other information
The actual affect of this simple page is to set a UserPreference item with the key
dark-lang, allowing staff to see what their Open edX looks like in a language which is not (yet) available to users in general. Assuming that this is a useful feature, we will need to reimplement the page in an MFE eventually. My thought is that the Account Settings page in frontend-app-account is the correct destination for this if and when it is written. If it is not rewritten, we will need to DEPR it.