bump dummy version #122
Merged
bump dummy version #122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
it is prerequisite of #116. As previous discussion, normal version bumping can't chang any code. So here I prepare the necessary code on image-tools repo. |
During bumping official version, it should not change any code. So, it has to prepare the version variables, their functions and dummy version (as 0.0.0-dev) into code. After that is landed, then official versions can be released. Signed-off-by: xiekeyang <[email protected]>
Member
|
LGTM |
Member
|
LGTM so that we can get |
cyphar
added a commit
that referenced
this pull request
Feb 27, 2017
Closes #122 LGTMs: @cyphar @coolljt0725
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During bumping official version, it should not change any code. So, it
has to prepare the version variables, their functions and dummy version
(as 0.0.0-dev) into code. After that is landed, then official versions
can be released.
Signed-off-by: xiekeyang [email protected]