Skip to content

Conversation

@znarf
Copy link
Member

@znarf znarf commented Jan 7, 2026

Also add extra coverage.

Replace: #11300 and #11059

znarf added 3 commits January 7, 2026 10:40
- Remove @simplewebauthn/types (now bundled in server package)
- Update type imports in webauthn.ts
- Add webauthn test coverage
@znarf znarf changed the title Update simplewebauthn Update simplewebauthn and related packages Jan 9, 2026
@znarf znarf marked this pull request as ready for review January 9, 2026 10:00
@znarf znarf requested a review from Copilot January 9, 2026 10:01
@znarf znarf requested a review from Betree January 9, 2026 10:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the @simplewebauthn/server package from version 11.0.0 to 13.2.2 and related @peculiar packages from 2.3.x to 2.6.0. The @simplewebauthn/types package is removed as its types are now exported directly from the server package in v13. Additional unit tests are added for WebAuthn functionality.

  • Updated @simplewebauthn/server from 11.0.0 to 13.2.2 and consolidated type imports
  • Updated @peculiar/asn1-x509 from 2.3.15 to 2.6.0
  • Added comprehensive unit tests for WebAuthn registration and authentication flows

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File Description
package.json Updates package versions for @simplewebauthn/server (11.0.0 → 13.2.2) and @peculiar/asn1-x509 (2.3.15 → 2.6.0), removes @simplewebauthn/types
package-lock.json Reflects dependency tree updates with new transitive @peculiar packages, removes cross-fetch and @simplewebauthn/types
server/lib/two-factor-authentication/webauthn.ts Consolidates type imports from @simplewebauthn/server instead of separate @simplewebauthn/types package
test/server/lib/two-factor-authentication/webauthn.test.ts Adds new unit tests for WebAuthn registration options, authentication options, and token validation

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@znarf znarf merged commit ba43996 into main Jan 12, 2026
37 of 41 checks passed
@znarf znarf deleted the upgrade-simplewebauthn branch January 12, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants