Skip to content

enhancement(Expense): protect invoice reference ID #11116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Betree wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

enhancement(Expense): protect invoice reference ID #11116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions server/graphql/common/expenses.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,6 +397,8 @@ export const canSeeExpenseInvoiceInfo: ExpensePermissionEvaluator = async (
) => {
if (!validateExpenseScope(req)) {
return false;
} else if (getContextPermission(req, PERMISSION_TYPE.SEE_EXPENSE_DRAFT_PRIVATE_DETAILS, expense.id)) {
return true;
}

return remoteUserMeetsOneCondition(
Expand Down
5 changes: 5 additions & 0 deletions server/graphql/v2/object/Expense.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,11 @@ export const GraphQLExpense = new GraphQLObjectType<ExpenseModel, Express.Reques
reference: {
type: GraphQLString,
description: 'User-provided reference number or any other identifier that references the invoice',
async resolve(expense, _, req) {
if (await ExpenseLib.canSeeExpenseInvoiceInfo(req, expense)) {
return expense.reference;
}
},
},
amount: {
type: new GraphQLNonNull(GraphQLInt),
Expand Down
Loading