chore: quick-win triage — global.json, test tooling, localization tests#124
Merged
shanselman merged 3 commits intomasterfrom Mar 31, 2026
Merged
chore: quick-win triage — global.json, test tooling, localization tests#124shanselman merged 3 commits intomasterfrom
shanselman merged 3 commits intomasterfrom
Conversation
…n tests - Add global.json to pin .NET SDK 10.0.x (rollForward: latestFeature) (closes #123) - Sync xunit.runner.visualstudio 3.1.0→3.1.4, add coverlet.collector to Tray.Tests (closes #90) - Add LocalizationValidationTests: key parity + format placeholder validation (closes #70) All 598 tests pass (503 shared + 95 tray). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
latestFeature picks up SDK 10.0.201 on CI runners, which requires MSBuild 18.0. The MSIX build step uses VS MSBuild 17.14.x, causing build failures. latestPatch keeps us in 10.0.1xx where MSBuild 17.x is compatible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
ARM64 runner only has 10.0.101, not 10.0.102. Using 10.0.100 as base with latestPatch finds any 10.0.1xx SDK (101 on ARM64, 104 on x64). Stays within the feature band where MSBuild 17.x is compatible. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three quick wins from Repo Assist triage:
1. Pin .NET SDK (closes #123)
Adds \global.json\ with
ollForward: latestFeature\ to prevent accidental .NET 11 jumps.
2. Sync test tooling (closes #90)
3. Localization validation tests (closes #70)
All 598 tests pass (503 shared + 95 tray).
Co-authored-by: Copilot 223556219+Copilot@users.noreply.github.com