[Repo Assist] refactor — eliminate ToLowerInvariant allocations in ChannelHealth; use TryGetValue in UpdateTrackedSession

[github-actions]

🤖 This is an automated PR from Repo Assist.

Summary

Two small, targeted refactors in Models.cs and OpenClawGatewayClient.cs:

1. ChannelHealth.IsHealthyStatus / IsIntermediateStatus — no more ToLowerInvariant allocation

Before:

public static bool IsHealthyStatus(string? status) =>
    status?.ToLowerInvariant() is "ok" or "connected" or "running" or "active" or "ready";

ToLowerInvariant() allocates a new string on every call. Both methods are invoked on every tray menu render cycle (once per channel via MenuDisplayHelper.GetChannelStatusIcon).

After:

private static readonly HashSet(string) s_healthyStatuses =
    new(StringComparer.OrdinalIgnoreCase) { "ok", "connected", "running", "active", "ready" };

public static bool IsHealthyStatus(string? status) =>
    status is not null && s_healthyStatuses.Contains(status);

• Zero allocation per call — HashSet.Contains with OrdinalIgnoreCase comparer does case-insensitive lookup without materialising a new string
• Same semantics — all existing tests pass unchanged

Consistent with the existing approach in the codebase (see PR #101 eliminating ToLowerInvariant in ClassifyByKeywords, PR #105 using FrozenDictionary in NotificationCategorizer).

---

2. UpdateTrackedSession — TryGetValue instead of ContainsKey + double-indexer

Before:

if (!_sessions.ContainsKey(sessionKey))
{
    _sessions[sessionKey] = new SessionInfo { ... };
}
_sessions[sessionKey].CurrentActivity = currentActivity;
_sessions[sessionKey].LastSeen = DateTime.UtcNow;

Three to four dictionary lookups for every call.

After:

if (!_sessions.TryGetValue(sessionKey, out var session))
{
    session = new SessionInfo { ... };
    _sessions[sessionKey] = session;
}
session.CurrentActivity = currentActivity;
session.LastSeen = DateTime.UtcNow;

• Two lookups (one for get-or-create, one insert if new)
• Local variable avoids repeated hash computation for the property updates
• Idiomatic C# — standard "get or add" pattern

---

Test Status

• dotnet test tests/OpenClaw.Shared.Tests/ → 503 passed, 18 skipped
• dotnet test tests/OpenClaw.Tray.Tests/ → 93 passed

All existing ChannelHealth.IsHealthyStatus / IsIntermediateStatus tests in ModelsTests.cs pass, confirming identical behaviour.

Generated by Repo Assist · ◷

To install this agentic workflow, run

gh aw add githubnext/agentics/workflows/repo-assist.md@cbb46ab386962aa371045839fc9998ee4e97ca64