Skip to content

Move filter to the right spot when calculating field names to request #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iandees merged 5 commits into from
Apr 11, 2025
Merged

Move filter to the right spot when calculating field names to request #75

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
63992a8
Make the test a bit more complicated
iandees Apr 10, 2025
f50777c
Revert "Make the test a bit more complicated"
iandees Apr 10, 2025
74def05
Add a case for string too
iandees Apr 10, 2025
42f23f4
Flip sorted and filter around
iandees Apr 10, 2025
023597b
Fix test
iandees Apr 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion openaddr/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,7 +360,7 @@ def field_names_to_request(cls, source_config):

if fields:
# Remove any blank or None values
return list(filter(None, sorted(fields)))
return list(sorted(filter(None, fields)))
else:
return None

Expand Down
3 changes: 2 additions & 1 deletion openaddr/tests/cache.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,12 +339,13 @@ def test_field_names_to_request(self):
"function": "constant",
"value": "123",
},
"region": "StateColumn",
}
}]
}
}), "addresses", "default")
fields11 = EsriRestDownloadTask.field_names_to_request(conform11)
self.assertEqual(fields11, ['Number', 'Street'])
self.assertEqual(fields11, ['Number', 'StateColumn', 'Street'])

def test_handle_feature_server_with_lat_lon_in_conform(self):
'''
Expand Down