-
Notifications
You must be signed in to change notification settings - Fork 0
Add Copilot instructions and .gitignore #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Unable to perform a code review. You have run out of credits 😔 |
Co-authored-by: 0xrinegade <[email protected]>
Co-authored-by: 0xrinegade <[email protected]>
…iled known issues Co-authored-by: 0xrinegade <[email protected]>
…ge context Co-authored-by: 0xrinegade <[email protected]>
Co-authored-by: 0xrinegade <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds comprehensive GitHub Copilot coding agent instructions and a standardized .gitignore file to improve developer experience and project maintainability. It establishes documentation for project structure, build processes, security requirements, and coding conventions for the svmai Rust CLI tool - a Solana wallet management application with a ratatui-based TUI.
Key Changes:
- Added 253-line
.github/copilot-instructions.mddocumenting project structure, build/test processes, security practices, CI/CD workflow, and development guidelines - Enhanced
.gitignorewith comprehensive Rust-specific exclusions including build artifacts, IDE files, OS files, and test coverage reports - Removed 2,083 committed build artifacts from the
target/directory (mentioned in description but not visible in diffs)
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.gitignore |
Adds additional Rust build artifacts (*.rs.bk, .pdb), OS files (.DS_Store, Thumbs.db), and test coverage exclusions (.profraw, cobertura.xml). Contains duplicate OS file entries that should be consolidated. |
.github/copilot-instructions.md |
Comprehensive 253-line guide covering project structure, build/test/lint processes, security requirements for Solana private keys, CI/CD checks, and development guidelines. Contains outdated "Known Issues" section describing compilation errors that have already been fixed, and references anyhow error handling library that isn't currently in dependencies. |
|
|
||
| ## Known Issues | ||
|
|
||
| - **Compilation Error**: The project currently has compilation errors due to the use of `Keypair::from_bytes(&key_bytes)` which was available in earlier versions of solana-sdk but has been removed in version 3.0.0. This affects three files: |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling error in "Compilation Error". The correct term should be "Compilation Errors" (plural) since multiple files are affected, or keep it as "Compilation Error" but clarify it's a single type of error affecting multiple locations.
| - **Compilation Error**: The project currently has compilation errors due to the use of `Keypair::from_bytes(&key_bytes)` which was available in earlier versions of solana-sdk but has been removed in version 3.0.0. This affects three files: | |
| - **Compilation Errors**: The project currently has compilation errors due to the use of `Keypair::from_bytes(&key_bytes)` which was available in earlier versions of solana-sdk but has been removed in version 3.0.0. This affects three files: |
|
|
||
| - Use `Result<T, E>` for fallible operations | ||
| - Propagate errors with `?` operator where appropriate | ||
| - Use `anyhow` for flexible error handling in application code |
Copilot
AI
Dec 12, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The instruction mentions using "anyhow" for error handling, but anyhow is not currently listed in Cargo.toml dependencies. It's only used in unintegrated modules (config.rs and logging.rs). The active codebase uses standard Result types like io::Result. Consider clarifying that anyhow will be used once those modules are integrated, or that it should be added as a dependency for new error handling code.
Configures GitHub Copilot coding agent instructions per best practices at https://gh.io/copilot-coding-agent-tips.
Changes
.github/copilot-instructions.md: 240-line guide covering:Keypair::from_bytesremoved in solana-sdk 3.0.0 (affects key_validator.rs:37, tui.rs:397, wallet_manager.rs:162) - migrate toKeypair::new_from_array([u8; 32])using first 32 bytes of keypairframe.size()deprecated in ratatui - useframe.area().gitignore: Standard Rust exclusions (target/, IDE files, coverage reports)Cleanup: Removed 2,083 committed build artifacts from target/
Example from instructions
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.