WEB-718 Show required error message for days till field in delinquency range form#3147
Open
JaySoni1 wants to merge 1 commit intoopenMF:devfrom
Conversation
|
Note
|
| Cohort / File(s) | Summary |
|---|---|
Error Display for maximumAgeDays src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html |
Added mat-error validation display block for maximumAgeDays field when required validation fails, mirroring existing error patterns for classification and minimumAgeDays fields. |
Estimated code review effort
🎯 1 (Trivial) | ⏱️ ~5 minutes
Possibly related PRs
- PR
#3051: Adds required validation for the maximumAgeDays field in the component, which this PR complements by adding the corresponding mat-error display in the template. - PR
#3113: Modifies minimumAgeDays handling in the same create-range component, providing related context for validation and error display patterns in this feature.
Suggested reviewers
- alberto-art3ch
- IOhacker
🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Merge Conflict Detection | ❌ Merge conflicts detected (21 files): ⚔️ README.md (content)⚔️ angular.json (content)⚔️ docker-compose.yml (content)⚔️ env.sample (content)⚔️ proxy.conf.js (content)⚔️ proxy.localhost.conf.js (content)⚔️ src/app/clients/client-stepper/client-general-step/client-general-step.component.html (content)⚔️ src/app/clients/client-stepper/client-general-step/client-general-step.component.scss (content)⚔️ src/app/clients/client-stepper/client-general-step/client-general-step.component.ts (content)⚔️ src/app/clients/clients.service.ts (content)⚔️ src/app/clients/edit-client/edit-client.component.html (content)⚔️ src/app/clients/edit-client/edit-client.component.scss (content)⚔️ src/app/clients/edit-client/edit-client.component.ts (content)⚔️ src/app/products/manage-delinquency-buckets/delinquency-range/create-range/create-range.component.html (content)⚔️ src/app/products/share-products/share-product-stepper/share-product-market-price-step/share-product-market-price-step.component.ts (content)⚔️ src/assets/env.js (content)⚔️ src/assets/env.template.js (content)⚔️ src/assets/translations/en-US.json (content)⚔️ src/environments/environment.prod.ts (content)⚔️ src/environments/environment.ts (content)⚔️ src/typings.d.ts (content)These conflicts must be resolved before merging into dev. |
Resolve conflicts locally and push changes to this branch. |
✅ Passed checks (3 passed)
| Check name | Status | Explanation |
|---|---|---|
| Description Check | ✅ Passed | Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | ✅ Passed | The title accurately describes the main change: adding a required error message for the 'Days Till' field in the delinquency range form, which is fully supported by the code modification. |
| Docstring Coverage | ✅ Passed | No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. |
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
✨ Finishing touches
🧪 Generate unit tests (beta)
- Create PR with unit tests
- Post copyable unit tests in a comment
⚔️ Resolve merge conflicts (beta)
- Auto-commit resolved conflicts to branch
WEB-718-show-required-error-message-for-days-till-field-in-delinquency-range-form - Post resolved changes as copyable diffs in a comment
No actionable comments were generated in the recent review. 🎉
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands and usage tips.
alberto-art3ch
requested changes
Feb 13, 2026
Collaborator
alberto-art3ch
left a comment
alberto-art3ch
left a comment
There was a problem hiding this comment.
Please see my comments
| <mat-label>{{ 'labels.inputs.Days Till' | translate }}</mat-label> | ||
| <input matInput type="number" required formControlName="maximumAgeDays" min="1" /> | ||
| @if (delinquencyRangeForm.controls.maximumAgeDays.hasError('required')) { | ||
| <mat-error> |
Collaborator
There was a problem hiding this comment.
The maximum days IS NOT required, It can be blank
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed Made :-
-Added a required error message for the "Days Till" field in the Delinquency Range creation form to ensure consistent validation feedback with the "Days From" field.
WEB-718
Before :-
After :-
Summary by CodeRabbit