Fix inverted collective_buffering hint logic #13700
Merged
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The collective_buffering hint had inverted logic due to incorrect use of strncmp. When set to 'true', it would disable collective buffering, and when set to 'false' it would enable it. Signed-off-by: Gonzalosilvalde <[email protected]>
Member
|
@edgargabriel could you review this and see if its good see which branches this needs to be cherry-picked back to? |
Member
|
seems like ZE CI had a glitch - rerunning |
edgargabriel
approved these changes
Jan 30, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The collective_buffering hint had inverted logic due to incorrect use of strncmp. When set to 'true', it would disable collective buffering, and when set to 'false' it would enable it.
The bug was in the strncmp comparison using sizeof("true") instead of the correct string length, combined with inverted conditional logic. Fixed by using strncasecmp with correct string length (5 for "false") and proper return value check (== 0).
Fixes #13377 and tested with the reproducer of the same issue (https://gist.github.com/carns/57b1e124460f3b2371d5219c747d0f10)