v6.0.x: coll/ucc: enable asymmetric datatype check in UCC without OMPI fallback #13658
v6.0.x: coll/ucc: enable asymmetric datatype check in UCC without OMPI fallback #13658QiaoK wants to merge 1 commit intoopen-mpi:v6.0.xfrom
Conversation
QiaoK
force-pushed
the
ompi_ucc_dt_check_6.0
branch
from
a5ec227 to
946266f
Compare
janjust
changed the title
jsquyres
left a comment
jsquyres
left a comment
There was a problem hiding this comment.
Is this not a cherry pick of #13656?
If it actually is a cherry-pick -- even if there was some back-porting necessary -- then this PR should not be marked as notacherrypick and the commit message should include the cherry pick message.
QiaoK
force-pushed
the
ompi_ucc_dt_check_6.0
branch
from
946266f to
d195d93
Compare
I updated the commit with cherry-pick message. |
jsquyres
changed the title
jsquyres
force-pushed
the
ompi_ucc_dt_check_6.0
branch
from
d195d93 to
dbd6a04
Compare
Thanks. Something is still wrong with our CI, though -- it should fail the git commit check if the commit you cherry picked from is not yet merged in its source branch (i.e., |
This change enables UCC to perform asymmetric datatype checks internally for gather, gatherv, scatter, and scatterv operations. This feature is only available in UCC 1.8 or greater. The motivation for this change is to avoid scenarios where a subset of processes fallback to OMPI while other processes proceed to UCC when asymmetric datatypes are supplied. By letting UCC handle the datatype asymmetry check, UCC can signal all processes to fallback when necessary, ensuring consistent collective operation execution across all ranks. Signed-off-by: Qiao Kang <qkang@nvidia.com> (cherry picked from commit ca0ef29)
QiaoK
force-pushed
the
ompi_ucc_dt_check_6.0
branch
from
dbd6a04 to
cf7c51f
Compare
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: cf7c51f: coll/ucc: enable asymmetric datatype check in UCC ...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
1 similar comment
|
Hello! The Git Commit Checker CI bot found a few problems with this PR: cf7c51f: coll/ucc: enable asymmetric datatype check in UCC ...
Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks! |
2 participants
This change enables UCC to perform asymmetric datatype checks internally for gather, gatherv, scatter, and scatterv operations. This feature is only available in UCC 1.8 or greater.
The motivation for this change is to avoid scenarios where a subset of processes fallback to OMPI while other processes proceed to UCC when asymmetric datatypes are supplied. By letting UCC handle the datatype asymmetry check, UCC can signal all processes to fallback when necessary, ensuring consistent collective operation execution across all ranks.