wipe the generalized request upon demand#13654
Open
bosilca wants to merge 1 commit intoopen-mpi:mainfrom
Open
Conversation
If the user calls MPI_Request_free on a generalized request, make sure the request, both user side and MPI side, is properly released. However, make sure the generalized request free_fn callback function will be called either in the MPI call MPI_REQUEST_FREE(request), or in the MPI call MPI_GREQUEST_COMPLETE(request), whichever happens last. Signed-off-by: George Bosilca <gbosilca@nvidia.com>
Contributor
|
I' may be doing something wrong, but this PR does not fix at all the error swallowing I reported in #11681. I tried again the very first reproducer in the issue description, and the behavior remains: the error returned from the free callback is not propagated out of the Please note that the related mpi4py tests are currently skipped in mpi4py@master. PS: Rather than closing my PR, it should have been used as a starting point for further simplification, if that is ever possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user calls MPI_Request_free on a generalized request, make sure the request, both user side and MPI side, is properly released. However, make sure the generalized request free_fn callback function will be called either in the MPI call MPI_REQUEST_FREE(request), or in the MPI call MPI_GREQUEST_COMPLETE(request), whichever happens last.
This is a sane replacement for #12392
Fixes #11681.