♻️ Code cleanup and refactoring for using static type hints#1645
Open
krish918 wants to merge 23 commits intoopen-edge-platform:mainfrom
Open
♻️ Code cleanup and refactoring for using static type hints#1645krish918 wants to merge 23 commits intoopen-edge-platform:mainfrom
krish918 wants to merge 23 commits intoopen-edge-platform:mainfrom
Conversation
- Updated REGISTRY_URL to REGISTRY - updated Docker dir; changed directory for compose file - added PROJECT_NAME and updated docker compose commands to use it - minor cleanups in script.sh Signed-off-by: Krishna Murti <[email protected]>
Signed-off-by: Krishna Murti <[email protected]>
…ndpoints Signed-off-by: Krishna Murti <[email protected]>
- Updated High traffic threshold to be 10 - for consistency across the components - Removed some comments and fixed typehints Signed-off-by: Krishna Murti <[email protected]>
- Removed game mode toggling logic, component and related icons on map from UI - Updated agent state model to remove fields related to blocked_routes and valid/invalid routes - Commented out more code from agent planner's real-time updates tool - related to gamification and route blocking/coloring - Updated game_data parameters from RouetService Logic and typehints updates Signed-off-by: Krishna Murti <[email protected]>
- for removing game setup, removed blocked_routes property and related impl. from RouteService class Signed-off-by: Krishna Murti <[email protected]>
- added quotes around variable interpolations in setup script - Updated docs for new script options like --setup and --stop Signed-off-by: Krishna Murti <[email protected]>
- updated lock file based on updates done for security alerts - Updated config to use localhost in host url - Removed the unused name field Signed-off-by: Krishna Murti <[email protected]>
- Also removed a method for adding game icons in maps based on game.json in MapCreator Signed-off-by: Krishna Murti <[email protected]>
Signed-off-by: Krishna Murti <[email protected]>
Signed-off-by: Krishna Murti <[email protected]>
…ting, type checking etc. - pre-commit config targets only the route-planner-agent Signed-off-by: Krishna Murti <[email protected]>
Signed-off-by: Krishna Murti <[email protected]>
- separated variable export from vraibale setting when using a comamnd to set a variable - so that return value of setting the variable is not masked by export command itself - Added checks for command execution while executing it, instead of checking value of $? on next line. Signed-off-by: Krishna Murti <[email protected]>
…y hook - Linting and formatting changes added to test_logging file Signed-off-by: Krishna Murti <[email protected]>
- Created new factory for StaticRouteOptimizers which returns a Callable based on given optimizer name - Minor formatting edits - Added type hints in function signatures and return types Signed-off-by: Krishna Murti <[email protected]>
- Updated indentation of pre-commit-config file for content to look less compact Signed-off-by: Krishna Murti <[email protected]>
Signed-off-by: Krishna Murti <[email protected]>
krish918
requested review from
a team,
bharagha,
madhuri-rai07 and
yogeshmpandey
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes # (issue)
NA
Any Newly Introduced Dependencies
NA
How Has This Been Tested?
Verified by deploying as per documentations and performing manual functional tests.
Checklist: