industrial-edge-insights-multimodal: Added simulation-data folder to … #1582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…image Changes: 1.weld-data-simulator/Dockerfile - Added simulation-data folder to the weld-simulator image 2.helm - Removed the work_dir env variable 3.docs- Updated and removed the work_dir env Signed-off-by: Pooja Kumbharkar <[email protected]>
pooja-intel
requested review from
a team,
SudarshanaPanda,
rashmihe,
sathyendranv,
sugnanprabhu,
vkb1 and
xwu2intel
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the external volume mount dependency for simulation data in the weld-data-simulator by embedding the simulation-data folder directly into the Docker image. This simplifies deployment by eliminating the need for users to configure the WORK_DIR environment variable and associated PersistentVolume/PersistentVolumeClaim resources.
Changes:
- Embedded simulation-data folder into the weld-data-simulator Docker image
- Removed WORK_DIR environment variable from Helm configuration and documentation
- Removed PersistentVolume and PersistentVolumeClaim resources for simulation data
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| weld-data-simulator/Dockerfile | Added COPY instruction to include simulation-data folder in the image |
| helm/values.yaml | Removed WORK_DIR environment variable and its documentation comments |
| helm/values.schema.json | Removed WORK_DIR validation schema |
| helm/templates/weld-data-simulator.yaml | Removed volume mount and volume definition for simulation-data |
| helm/templates/provision-configmap.yaml | Removed PersistentVolume and PersistentVolumeClaim definitions for simulation-data |
| docs/user-guide/how-to-guides/how-to-deploy-with-helm.md | Removed WORK_DIR configuration instruction from deployment guide |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
vkb1
approved these changes
Jan 29, 2026
sathyendranv
approved these changes
Feb 2, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…image
Changes:
1.weld-data-simulator/Dockerfile - Added simulation-data folder to the weld-simulator image
2.helm - Removed the work_dir env variable
3.docs- Updated and removed the work_dir env
Description
Please include a summary of the changes and the related issue. List any dependencies that are required for this change.
Fixes # (issue)
Any Newly Introduced Dependencies
No.
How Has This Been Tested?
Yes
Checklist: