todo utils, helpers and specs #387

ethanbalgobin · 2025-11-18T23:19:16Z

Description

This pull request adds end-to-end testing for the TODO list feature.
The test suite covers all core TODO functionality including:

Opening and closing the TODO list via UI, keyboard shortcuts (Shift+T+S, Shift+T+N), and command palette
Creating TODOs with various field combinations (title only, with description, with priority, all fields)
Creating multiple TODOs using the "Create More" checkbox
Updating TODO fields (title, description, priority) individually and in combination
Marking TODOs as complete/incomplete with visual feedback verification
Deleting TODOs in various states (open, completed)
Edge cases including disabled editing on completed TODOs and empty state display
The implementation follows the Page Object Model pattern with dedicated sections for the TODO list, create form, and edit form, along with helper functions and test data generators for maintainability and reusability.

Dependencies

List of the dependencies for this change, otherwise omit this section.

Screenshots

Screenshots if applicable, otherwise omit this section.

Testing instructions

Ensure the development environment is running:

docker-compose up -d

Run all TODO E2E tests:

cd web
npm run test:e2e -- --grep "@todo"

Run specific test suites:

  # Test TODO creation
   npm run test:e2e -- todo-create-spec.ts
   
   # Test TODO updates
   npm run test:e2e -- todo-update.spec.ts
   
   # Test TODO completion
   npm run test:e2e -- todo-complete.spec.ts
   
   # Test TODO deletion
   npm run test:e2e -- todo-delete.spec.ts
   
   # Test TODO list open/close
   npm run test:e2e -- todo-open-close.spec.ts

Verify all 19 tests pass successfully.

Checklist

I have read and understood the Developer's Certificate of Origin and
added Signed-off-by: <YOUR NAME> to the commit trail where <YOUR NAME> is
my name.

boring-cyborg · 2025-11-18T23:19:24Z

Thanks for opening this pull request! 🥳
Please check out our contributing guide.
If you have any questions, please ask in the #development channel in our
Slack or Discord.
Happy coding! 🚀

vercel · 2025-11-18T23:19:27Z

@ethanbalgobin is attempting to deploy a commit to the Opcotech Team on Vercel.

A member of the Team first needs to authorize it.

Signed-off-by: Ethan Balgobin <[email protected]>

codecov · 2025-11-19T08:14:14Z

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gabor-boros

I mostly have minor comments related to formatting and TodoPriority type usage. However, some e2e tests seems to fail (mostly due to duplicated element selector results).

gabor-boros · 2025-11-19T07:59:21Z

web/tests/e2e/helpers/index.ts

 export * from "./pages";
 export * from "./permissions";
 export * from "./toast";
+export * from "./todo";


Suggested change

export * from "./todo";

export * from "./todo";

gabor-boros · 2025-11-19T07:59:55Z

web/tests/e2e/helpers/todo.ts

+  await page.getByPlaceholder(/Type a command/i).waitFor();
+  await page.getByRole("option", { name: /Add Todo/i }).click();
+  await page.getByRole("heading", { name: "Add Todo" }).waitFor();
+}


Suggested change

}

}

gabor-boros · 2025-11-19T08:01:04Z

web/tests/e2e/sections/todo-create-form-section.ts

+    }
+    await this.submit();
+  }
+}


Suggested change

}

}

gabor-boros · 2025-11-19T08:19:04Z

web/tests/e2e/sections/todo-edit-form-section.ts

+  async fillTodoFields(fields: {
+    title?: string;
+    description?: string;
+    priority?: "normal" | "important" | "urgent" | "critical";


I think we have a TodoPriority type in the generated client that we could use here.

gabor-boros · 2025-11-19T08:22:19Z

web/tests/e2e/sections/todo-edit-form-section.ts

+  async updateTodo(fields: {
+    title?: string;
+    description?: string;
+    priority?: "normal" | "important" | "urgent" | "critical";


If the TodoPriority type exists, we could use that here too.

gabor-boros · 2025-11-19T08:23:43Z

web/tests/e2e/utils/todo.ts

+    priority: "important",
+    dueDate: tomorrow,
+  };
+}


Suggested change

}

}

gabor-boros · 2025-11-19T08:24:51Z

web/tests/e2e/todo-complete.spec.ts

+    // Check for reduced opacity on todo item
+    await expect(todoItem).toHaveClass(/opacity-75/);
+  });
+});


Suggested change

});

});

gabor-boros · 2025-11-19T08:25:18Z

web/tests/e2e/todo-create-spec.ts

+    await waitForSuccessToast(page, "Todo added successfully");
+    expect(await todoSection.getTodoCount()).toBeGreaterThanOrEqual(2);
+  });
+});


Suggested change

});

});

gabor-boros · 2025-11-19T08:25:29Z

web/tests/e2e/todo-open-close.spec.ts

+
+    expect(await todoSection.isOpen()).toBe(true);
+  });
+});


Suggested change

});

});

gabor-boros · 2025-11-19T08:25:39Z

web/tests/e2e/todo-update.spec.ts

+    const editButton = todoItem.getByTitle("Edit todo");
+    expect(await editButton.isDisabled()).toBe(true);
+  });
+});


Suggested change

});

});

@gabor-boros Thanks for the feedback, will get these sorted!

ethanbalgobin added 2 commits November 17, 2025 23:11

test: todo page tests

45feac7

todo utils, helpers and specs

1b43f29

ethanbalgobin requested review from a team as code owners November 18, 2025 23:19

boring-cyborg bot added the component: front-end label Nov 18, 2025

Signing off commit

a2ab77e

Signed-off-by: Ethan Balgobin <[email protected]>

gabor-boros reviewed Nov 19, 2025

View reviewed changes

gabor-boros added this to the v0.1.0 - MVP milestone Nov 19, 2025

gabor-boros linked an issue Nov 19, 2025 that may be closed by this pull request

E2e tests for the todo list #264

Open

21 tasks

gabor-boros added type: pedantic status: in-progress priority: P2 - Low language: TypeScript labels Nov 19, 2025

todo utils, helpers and specs #387

Are you sure you want to change the base?

todo utils, helpers and specs #387

Uh oh!

Conversation

ethanbalgobin commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Dependencies

Screenshots

Testing instructions

Checklist

Uh oh!

boring-cyborg bot commented Nov 18, 2025 • edited by gabor-boros Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

vercel bot commented Nov 18, 2025

Uh oh!

codecov bot commented Nov 19, 2025

Codecov Report

Uh oh!

gabor-boros left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ethanbalgobin commented Nov 18, 2025 •

edited

Loading

boring-cyborg bot commented Nov 18, 2025 •

edited by gabor-boros

Loading