Skip to content

Conversation

@gabor-boros
Copy link
Member

@gabor-boros gabor-boros commented Nov 8, 2025

Description

This PR closes #318 with all of its subtasks:

Also, it refactors the way we do end to end tests to make them more reliable and easier to work with.

Dependencies

N/A

Screenshots

Details Screenshot 2025-11-10 at 10-51-25 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-50-40 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-50-34 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-50-05 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-49-57 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-45-36 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-45-28 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-45-01 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-43-43 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-43-25 Elemo - The next generation project management platform Screenshot 2025-11-10 at 10-43-17 Elemo - The next generation project management platform

Testing instructions

  1. Login as demo user
  2. Create a new role
  3. Assign some permissions (for existing resources)
  4. Add Hector members to the new role
  5. Invite a new member to the org and, -- in a private browser session --, accept the invitation
  6. Add the new member to roles
  7. Check if the new member has permission/access to the org
  8. Remove the new member

Checklist

@vercel
Copy link

vercel bot commented Nov 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
elemo-api-docs Ignored Ignored Nov 10, 2025 6:38am
elemo-marketing Ignored Ignored Nov 10, 2025 6:38am

@gabor-boros gabor-boros force-pushed the add-org-member-management branch from 0964a73 to 306a905 Compare November 9, 2025 21:06
@opcotech opcotech deleted a comment from codecov bot Nov 10, 2025
@gabor-boros gabor-boros marked this pull request as ready for review November 10, 2025 07:00
@gabor-boros gabor-boros requested review from a team as code owners November 10, 2025 07:00
@opcotech opcotech deleted a comment from codecov bot Nov 10, 2025
@gabor-boros gabor-boros merged commit 706426c into main Nov 10, 2025
18 of 19 checks passed
@gabor-boros gabor-boros deleted the add-org-member-management branch November 10, 2025 07:29
@codecov
Copy link

codecov bot commented Nov 10, 2025

Codecov Report

❌ Patch coverage is 32.57373% with 503 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
internal/transport/http/organization.go 0.00% 215 Missing ⚠️
internal/service/organization.go 39.68% 107 Missing and 45 partials ⚠️
internal/service/role.go 31.53% 62 Missing and 14 partials ⚠️
internal/repository/neo4j/organization.go 60.71% 26 Missing and 7 partials ⚠️
internal/transport/http/permission.go 0.00% 7 Missing ⚠️
internal/pkg/convert/convert.go 82.35% 3 Missing and 3 partials ⚠️
internal/repository/redis/role.go 0.00% 2 Missing and 2 partials ⚠️
internal/service/user.go 0.00% 4 Missing ⚠️
internal/repository/neo4j/permission.go 62.50% 1 Missing and 2 partials ⚠️
internal/transport/http/user.go 0.00% 2 Missing ⚠️
... and 1 more
Files with missing lines Coverage Δ
internal/email/auth.go 100.00% <ø> (ø)
internal/email/organization.go 100.00% <ø> (ø)
internal/model/auth.go 100.00% <100.00%> (ø)
internal/model/permission.go 100.00% <100.00%> (ø)
internal/repository/neo4j/edge.go 100.00% <ø> (ø)
internal/repository/redis/organization.go 95.55% <100.00%> (+0.81%) ⬆️
internal/service/email.go 96.87% <100.00%> (-0.10%) ⬇️
internal/service/service.go 78.37% <100.00%> (+1.90%) ⬆️
internal/transport/http/role.go 0.00% <0.00%> (ø)
internal/transport/http/user.go 0.00% <0.00%> (ø)
... and 9 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment