Skip to content

Conversation

@DecFox
Copy link
Contributor

@DecFox DecFox commented Apr 1, 2025

Checklist

Description

This diff allows disabling default enabled tests in the engine using the checkin api. The summary of changes are:

  • if a nettest is enabled by the engine but disabled by checkin and the web_connectivity experiment was run in the last 24 hours, the nettest would throw an error and not run

  • if the checkin cache has expired and web_connectivity was not called in the last 24 hours, the nettest will run and switch to default behaviour

Apart from this, the running should WAI i.e., if the nettest is disabled by default in the engine, we will check the OONI_FORCE_ENABLE_EXPERIMENT env variable and also the checkin cache. However, if a checkin cache is not found at this point, the test will fail to run and throw an error. It is only when we find an explicit permission from the checkin cache that we allow a disabled test to run

@DecFox DecFox requested a review from hellais as a code owner April 1, 2025 07:58
@DecFox DecFox merged commit 88d819f into master Apr 8, 2025
16 of 19 checks passed
@DecFox DecFox deleted the feat/allow-checkin-disable branch April 8, 2025 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants