-
Notifications
You must be signed in to change notification settings - Fork 2
Add length indicators to test fixtures #131
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: ony3000 <[email protected]>
- Added length indicators to 129 fixture files - Fixed astro frontmatter tests to place indicators inside frontmatter - Updated 2070 test snapshots to include length indicators - All 4872 tests passing Co-authored-by: ony3000 <[email protected]>
ony3000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot 대부분의 수정 사항은 의도한 대로 작성되었다. 하지만 일부 수정 사항은 고칠 필요가 있다.
-
우선, astro 테스트에서
-문자열을 반복하는 횟수에 대한 규칙을 정정한다.- frontmatter 내부에 JS 주석을 작성하는 케이스는 처음 지시한 것과 동일하다. ((printWidth 값 - 2)만큼)
- frontmatter 아래에 HTML 주석을 작성하는 케이스는, 해당 테스트의 frontmatter 유무에 따라 다르다.
- frontmatter가 있는 테스트에 HTML 주석을 작성하는 케이스는 처음 지시한 것과 동일하다. ((printWidth 값 - 5)만큼)
- frontmetter가 없는 테스트에 HTML 주석을 작성하는 케이스는 (printWidth 값 - 6)만큼 반복되어야 한다.
정정한 규칙을 바탕으로 모든 astro 테스트를 점검하라.
-
babel/others/fixtures.ts,typescript/others/fixtures.ts,html/issue-80/fixtures.ts에 길이 표시자가 추가되지 않은 테스트가 하나씩 있다. 각 테스트에 알맞는 길이 표시자를 추가하라.
다음은 추가 요청 사항이다.
-
markdown 테스트와 mdx 테스트에 알맞는 길이 표시자를 추가하라.
-
모든
issue-68테스트를 점검하고, 길이 표시자가 올바르지 않은 테스트를 수정하라.
- Added missing indicators to babel/others, typescript/others, html/issue-80 - Fixed issue-68 tests (svelte, vue, astro) to use HTML comments - Added indicators to all markdown and mdx tests - Fixed astro tests without frontmatter to use printWidth-6 dashes - Updated 356 snapshots Co-authored-by: ony3000 <[email protected]>
All feedback addressed in commit 382ecc1:
All 4872 tests passing. |
ony3000
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot 대부분의 수정 사항은 의도한 대로 작성되었다. 하지만 astro 테스트 중 일부는 JS 주석을 HTML 주석으로 수정해야 한다.
수정이 필요한 테스트마다 코멘트를 남겨두었다.
- Changed JS comments to HTML comments in tests inside <script> tags - Changed JS comments to HTML comments for class:list directive tests - Changed JS comments to HTML comments for unsupported attributes/functions - Changed JS comments to HTML comments for custom attributes - Updated 32 snapshots Co-authored-by: ony3000 <[email protected]>
Fixed in commit c54412f. Changed JS comments to HTML comments for 16 astro tests in template sections (tests inside |
✅ Completed: Add Length Indicators to Test Fixtures
All feedback addressed and tests passing.
Changes Made:
1. Fixed Missing Length Indicators:
babel/others/fixtures.ts- Added indicator to "class name inside the 'if' block" testtypescript/others/fixtures.ts- Added indicator to "class name inside the 'if' block" testhtml/issue-80/fixtures.ts- Added indicator to test Separate test code into different branches #52. Fixed issue-68 Tests:
//) to HTML comments (<!-- -->) for:svelte/issue-68/fixtures.tsvue/issue-68/fixtures.tsastro/issue-68/fixtures.ts3. Added Indicators to Markdown/MDX:
markdown/issue-80/fixtures.ts- All 6 tests now have HTML comment indicatorsmdx/issue-80/fixtures.ts- All 6 tests now have HTML comment indicators4. Fixed Astro Dash Count Rules:
printWidth - 5toprintWidth - 6dashes (22 files fixed)printWidth - 5dashes (correct)printWidth - 2dashes (correct)5. Fixed Astro Template Section Comments (Latest):
<script>tags (issue-73: 2 tests)class:listdirective (8 tests across multiple files)Rule Clarification:
Only code inside Astro frontmatter (between
---delimiters) should use JS comments. Everything else in Astro template files should use HTML comments, even code inside<script>tags.Test Results:
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.