Fix update_info behavior to preserve appliance_id on partial API errors#44
Closed
alexskr wants to merge 1 commit intoontoportal:masterfrom
Closed
Fix update_info behavior to preserve appliance_id on partial API errors#44alexskr wants to merge 1 commit intoontoportal:masterfrom
alexskr wants to merge 1 commit intoontoportal:masterfrom
Conversation
- Refactored `update_info` method to always assign @update_info, even if the API response includes an "error" key. - Ensured that partial failures (e.g., update check error) do not prevent access to valid fields like appliance_id. - Updated method to use a keyword argument (`render_response: true`) instead of a positional boolean, improving readability and satisfying Rubocop guidelines.
Contributor
Author
|
wrong repo |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
update_infomethod to always assign @update_info, even if the API response includes an "error" key.render_response: true) instead of a positional boolean, improving readability and satisfying Rubocop guidelines.