Skip to content

Conversation

@janezpodhostnik
Copy link
Contributor

@janezpodhostnik janezpodhostnik commented Jan 9, 2026

Upgrading mockery to v3

It was relatively smooth.
I added a script to find all unused mocks, so they can be deleted. I used this to exclude generating mocks for all packages we are not currently using.

I would need someone from consensus to help me with this folder: engine/consensus/approvals. I had to move the tests to a testing package (otherwise there was a cycle, because the approvals package is needed to generate the mocks, but it also uses the mocks) but the tests are accessing some private fields.

I expect this will have conflicts often, so I will updated only after its reviewed.

@janezpodhostnik janezpodhostnik self-assigned this Jan 9, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 9, 2026

Important

Review skipped

Too many files!

150 files out of 300 files are above the max files limit of 150.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 9, 2026

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@janezpodhostnik janezpodhostnik marked this pull request as ready for review January 13, 2026 15:31
@janezpodhostnik janezpodhostnik requested a review from a team as a code owner January 13, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants