Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading mockery to v3
It was relatively smooth.
I added a script to find all unused mocks, so they can be deleted. I used this to exclude generating mocks for all packages we are not currently using.
I would need someone from consensus to help me with this folder:
engine/consensus/approvals. I had to move the tests to a testing package (otherwise there was a cycle, because the approvals package is needed to generate the mocks, but it also uses the mocks) but the tests are accessing some private fields.I expect this will have conflicts often, so I will updated only after its reviewed.