fix(FLOW-15): Return per-token balances in getPendingRequestsByUserUnpacked #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…packed
Previously, `getPendingRequestsByUserUnpacked` only returned native FLOW
balances, ignoring ERC20/WFLOW balances. This made it impossible for
clients to see pending balances for non-native tokens.
Changes:
- Solidity: Return `balanceTokens[]`, `pendingBalances[]`, and
`claimableRefundsArray[]` instead of single uint256 values
- Cadence: Update `PendingRequestsInfo` struct to use dictionaries
`pendingBalances: {String: UFix64}` and `claimableRefunds: {String: UFix64}`
- Update ABI decoding to handle new array types
- Update all tests to use new return format
Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #30
Previously,
getPendingRequestsByUserUnpackedonly returned native FLOW balances, which made it harder for clients to surface per-token pending/refund balances.Note:
balanceTokens/pendingBalances/claimableRefundsArraycurrently coverNATIVE_FLOWand (when configured)WFLOWonly. Other supported ERC20 balances remain queryable viagetUserPendingBalance(user, token)andgetClaimableRefund(user, token).Changes:
balanceTokens[],pendingBalances[], andclaimableRefundsArray[]instead of single uint256 valuesPendingRequestsInfostruct to use dictionariespendingBalances: {String: UFix64}andclaimableRefunds: {String: UFix64}Test plan
🤖 Generated with Claude Code