Enforce liquidation pause and warmup period checks #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pause/warmup validation to manualLiquidation() by calling the existing _assertLiquidationsActive() function. Implement previously empty test stubs for pause and warmup scenarios, and add test helper functions and governance transaction for pause control. Changes: - Call _assertLiquidationsActive() in manualLiquidation() - Add pause_liquidations.cdc governance transaction - Implement testManualLiquidation_liquidationPaused() - Implement testManualLiquidation_liquidationWarmup() - Add pauseLiquidations() and getLiquidationParams() test helpers All 20 liquidation tests pass, including the 2 new tests. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Add pause/warmup validation to manualLiquidation() by calling the existing _assertLiquidationsActive() function. Implement previously empty test stubs for pause and warmup scenarios, and add test helper functions and governance transaction for pause control. Changes: - Call _assertLiquidationsActive() in manualLiquidation() - Add pause_liquidations.cdc governance transaction - Implement testManualLiquidation_liquidationPaused() - Implement testManualLiquidation_liquidationWarmup() - Add pauseLiquidations() and getLiquidationParams() test helpers All 20 liquidation tests pass, including the 2 new tests. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Apply liquidation bonus tolerance to manual liquidation DEX price comparison. Manual liquidators can now propose offers up to bonus% worse than DEX price, incentivizing manual liquidations when automated DEX liquidations are unavailable. Changes: - Modify DEX validation to use bonus-adjusted max seize amount - Add governance transaction for setting token liquidation bonus - Add test helper for configuring bonus in tests - Add 4 new tests covering bonus validation scenarios - Update existing test to maintain strict validation behavior All liquidation tests passing (24/24). Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
The testManualLiquidation_bonusZero_requiresStrictlyBetter test is equivalent to the existing testManualLiquidation_liquidatorOfferWorseThanDex test, which was updated to set bonus=0. Co-Authored-By: Claude Sonnet 4.5 <[email protected]>
Member
Author
|
Converting to draft until liquidation bonus is removed per https://flow-foundation.slack.com/archives/C08QF29F7TK/p1769117611306279?thread_ts=1769039360.449179&cid=C08QF29F7TK. |
…n-pause-enforcement
turbolent
reviewed
Jan 27, 2026
Gornutz
approved these changes
Jan 27, 2026
joshuahannan
approved these changes
Jan 27, 2026
| pre { | ||
| !self.liquidationsPaused: | ||
| "Liquidations paused" | ||
| !self.liquidationsPaused: "Liquidations paused" |
Member
There was a problem hiding this comment.
I don't really like assertions like this. I think it is better to have this function return a Boolean and then the calling function can check that and provide a more descriptive error message if it fails. This isn't critical, but just a suggestion
Member
Author
|
Thread on liquidation vs global pause: https://flow-foundation.slack.com/archives/C08QF29F7TK/p1769540691604539 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will likely be replaced by global pause mechanism -- see #126