Skip to content

Conversation

@aaron-diaz
Copy link
Contributor

@aaron-diaz aaron-diaz commented Oct 23, 2024

#93

Aun me falta agregar la columna al excel

Edit: Listo

@aaron-diaz aaron-diaz requested a review from Juanito98 October 23, 2024 07:33
@aaron-diaz aaron-diaz marked this pull request as draft October 23, 2024 07:37
@aaron-diaz aaron-diaz self-assigned this Oct 26, 2024
@aaron-diaz aaron-diaz marked this pull request as ready for review October 26, 2024 08:12
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Puedes exponer esta API en la consola de /admin?
Es simplemente agregándolo a APIS en /src/components/admin/client

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Podrías agregarlo a la consola de admin? Para que los admin lo puedan empezar a usar

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

La de create y la de update. Despues podemos buscar una mejor manera de re diseñar la consola

@aaron-diaz aaron-diaz marked this pull request as draft November 5, 2024 18:12
@aaron-diaz
Copy link
Contributor Author

Faltan los tests.

@aaron-diaz aaron-diaz marked this pull request as ready for review March 7, 2025 05:45
@aaron-diaz aaron-diaz requested review from Juanito98 and YOSSHUA March 7, 2025 05:45
@aaron-diaz aaron-diaz requested a review from Juanito98 March 8, 2025 05:36
updatedAt DateTime @updatedAt
Disqualification Disqualification? @relation(fields: [DisqualificationId], references: [id])
DisqualificationId String?
Mentoria Mentoria[]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por qué renombramos Mentorias a Mentoria? No rompe nada más?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. No recuerdo porque lo hice, seguro fue un error. Lo cambio en breve.

it("should send email when sendEmail is true", async () => {
const { req, res } = mockRequestResponse({ body: validRequest });

await prisma.participation.create({
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Podríamos pasar la creación de la participación a un método? Vi que se repite varias veces

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants