-
Notifications
You must be signed in to change notification settings - Fork 4
[Feature] Descalificar participantes #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Puedes exponer esta API en la consola de /admin?
Es simplemente agregándolo a APIS en /src/components/admin/client
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 Podrías agregarlo a la consola de admin? Para que los admin lo puedan empezar a usar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
La de create y la de update. Despues podemos buscar una mejor manera de re diseñar la consola
|
Faltan los tests. |
prisma/migrations/20241114064745_disqualificationid_and_contestantparticipationid/migration.sql
Outdated
Show resolved
Hide resolved
| updatedAt DateTime @updatedAt | ||
| Disqualification Disqualification? @relation(fields: [DisqualificationId], references: [id]) | ||
| DisqualificationId String? | ||
| Mentoria Mentoria[] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Por qué renombramos Mentorias a Mentoria? No rompe nada más?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. No recuerdo porque lo hice, seguro fue un error. Lo cambio en breve.
| it("should send email when sendEmail is true", async () => { | ||
| const { req, res } = mockRequestResponse({ body: validRequest }); | ||
|
|
||
| await prisma.participation.create({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Podríamos pasar la creación de la participación a un método? Vi que se repite varias veces
#93
Aun me falta agregar la columna al excel
Edit: Listo