Option to add roi comment when adding ROI from OMERO #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a checkbox to give the possibility to load the shape comment when an ROI is added from OMERO:
The checkbox is currently checked by default, and the properties of the text are assigned by default to the values of the ShapeManager (
fillOpacity,fillColor,fontSize,fontColor,textAnchor)The iviewer places the comments differently for polylines and polygon, so I think I should change the default XY position.
How the iviewer shows the shapes:
The comments in iviewer also have a fontSize, but the color is the same as the shape color.
I think it's best to use the ShapeManager values to set for the comments in figure (i.e. controlling the appearance of the labels from figure, not from iviewer and refresh)