Open
Conversation
jack-greenberg
requested changes
Nov 30, 2020
Contributor
jack-greenberg
left a comment
jack-greenberg
left a comment
There was a problem hiding this comment.
Nice work dude! Few notes:
- You're using the old buck design, you need to place the fuse before the zener diode to prevent current spikes from damaging the diode
Yours
What it should be
- Make sure to run annotation to label things (so like J2 instead of J?)
- Your resistor R2 (near the CAN transceiver) should be a specific part: R_120_DNP
Send me a text when u implement this!
Author
|
Requested changes were made to the schematic! I ran the DRC and found there were some other errors with the net labels which should be fixed now. |
Contributor
|
Sweet, looks good! Go through the EDC (design checklist) and make any necessary updates, and lmk when you are done and I'll merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will automatically be updated (I think...) with any work @nonas-hunter uploads to github.