Draft
Conversation
There are two common configuration errors that developers run into: - Invalid API token - Invalid Org URL (DNS name not found) In either situation, the underlying HTTP error bubbles up the promise chain. If the developer has not implemented a catch, they get a generic error about an uncaught promise exception This improves on that by printing the exceptions for the common cases above, then exiting the process with a non-zero code
Contributor
|
I definitely support logging the error. Killing the process may be a bit severe. The Okta integration could be a small part of a much larger application. |
Contributor
Author
That's a good point, we shouldn't exit. I was doing the exit to try to avoid the "UnhandledPromiseRejectionWarning" also being printed, but maybe there's not a good way to do that? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two common configuration errors that developers run into:
In either situation, the underlying HTTP error bubbles up the promise chain.
If the developer has not implemented a catch, they get a generic error about an uncaught promise exception
This improves on that by printing the exceptions for the common cases above, then exiting the process with a non-zero code
You can reproduce the problematic case by running this: