Conversation
c170837 to
be9c0fa
Compare
be9c0fa to
417dcf6
Compare
|
Please remove the debug print statement on line 217: print('String e: '+ str(e))This should either be removed entirely or replaced with proper logging using Python's |
Regarding the print statement: You are right, that was left over from my debugging session where standard logging wasn't capturing the output. I will remove it to keep the library output clean. Regarding re-raising the exception: I would advise against re-raising here. The critical issue this PR fixes is that a single failure causes the library to hang indefinitely on subsequent calls because the cache holds onto a failed future. The goal of this block is cleanup: we catch the failure, remove the bad entry from the cache, and allow the program to continue. If we re-raise, we stop the execution flow, which defeats the purpose of allowing the application to recover and retry on the next tick. I want to ensure the library handles the network disconnect gracefully rather than crashing the process." |
Uh oh!
There was an error while loading. Please reload this page.