Open
Conversation
Because you only want to check if textToSearch contains substring.
length of string is implicit
length of string is implicit
Is the append per line approach really more readable considering the logic. I'd argue it is not so why not keep the size of the byte code minimal more info: https://stackoverflow.com/questions/37672785/how-can-i-improve-performance-if-append-is-called-on-stringbuffer-or-stringb
Contributor
|
@sekaiser Thanks for your PR! I will review your PR. Can you please sign the CLA at okta.com/CLA ? |
Author
|
Hi @arvindkrishnakumar-okta thanks for taking the time to review this PR. I alreday signed the CLA on 13th of May. |
Contributor
|
Thank you, I’ll get this merged soon.On Jun 24, 2023, at 8:32 AM, Sebastian Kaiser ***@***.***> wrote:
This message originated outside your organization.
Hi @arvindkrishnakumar-okta thanks for taking the time to review this PR.
I alreday signed the CLA on 13th of May.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About this change - What it does
Proposes small changes to the code base without changing the behavior or adding new features.
Proposed changes are about readability and simplification.
I tried to stick to one commit per change to support the reviewer.